From 303b7d13c53f780993510b4c45cf0b9975b7f690 Mon Sep 17 00:00:00 2001 From: Laurel Fulford Date: Tue, 7 Apr 2026 14:42:52 -0700 Subject: [PATCH 1/2] feat: swap in Overlay Menu block to replace templtae parts --- AGENTS.md | 1 - parts/drawer-contents.html | 17 -------------- parts/mobile-contents.html | 19 --------------- parts/mobile-menu.html | 7 ------ patterns/drawer-menu.php | 27 ---------------------- patterns/header/header-desktop-style-2.php | 7 +++++- patterns/header/header-desktop-style-3.php | 7 +++++- patterns/header/header-desktop-style-4.php | 7 +++++- patterns/header/header-mobile-style-1.php | 7 +++++- patterns/header/header-mobile-style-2.php | 7 +++++- patterns/header/header-mobile-style-3.php | 7 +++++- patterns/header/header-mobile-style-4.php | 7 +++++- patterns/header/header-mobile-style-5.php | 7 +++++- patterns/header/header-mobile-style-6.php | 7 +++++- src/js/front-end/main.js | 2 -- src/js/front-end/menus/drawer.js | 14 ----------- src/js/front-end/menus/mobile.js | 14 ----------- src/scss/overlays/_drawer.scss | 26 --------------------- src/scss/style.scss | 1 - 19 files changed, 54 insertions(+), 137 deletions(-) delete mode 100644 parts/drawer-contents.html delete mode 100644 parts/mobile-contents.html delete mode 100644 parts/mobile-menu.html delete mode 100644 patterns/drawer-menu.php delete mode 100644 src/js/front-end/menus/drawer.js delete mode 100644 src/js/front-end/menus/mobile.js delete mode 100644 src/scss/overlays/_drawer.scss diff --git a/AGENTS.md b/AGENTS.md index a77a307a..11b21c26 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -19,5 +19,4 @@ Do not add new blocks to this repo. New blocks should be added to `newspack-plug - **External patterns are intentionally blocked.** The theme prevents Jetpack, WooCommerce, and Automattic remote patterns from loading. This is by design — do not remove these filters. - **After adding a new PHP class file, run `composer dump-autoload`.** The `includes/` directory uses classmap autoloading, not PSR-4. - **The Article Subtitle block has two completely different implementations.** In the post editor it is not a block at all — it injects a `contenteditable` div directly into the DOM and updates post meta via `editPost()`. In the site editor it registers normally via `registerBlockType()`. Modifying it requires understanding which context you are in. -- **There are two separate menu systems with different selectors.** Mobile headers use `.header-mobile` (container), `.mobile-menu__toggle` / `.mobile-menu__contents` (handled by `menus/mobile.js`). Drawer menus used in some desktop header patterns use `.drawer-menu` (container), `.drawer-menu__toggle` / `.drawer-menu__contents` (handled by `menus/drawer.js`). Mixing up the selectors or JS handlers will silently break menu initialization. - **Style variations require a unique `className` in their JSON.** The theme reads `wp_get_global_settings()['custom']['className']` and adds it as a `theme-variation-{className}` body class used for CSS scoping. A new style variation in `styles/` must define this value or scoped styles will not apply. diff --git a/parts/drawer-contents.html b/parts/drawer-contents.html deleted file mode 100644 index 4bb6ff52..00000000 --- a/parts/drawer-contents.html +++ /dev/null @@ -1,17 +0,0 @@ - -
- -
- - - -
- - - -
- diff --git a/parts/mobile-contents.html b/parts/mobile-contents.html deleted file mode 100644 index 4e023d47..00000000 --- a/parts/mobile-contents.html +++ /dev/null @@ -1,19 +0,0 @@ - -
- -
- - - -
- - - - - -
- diff --git a/parts/mobile-menu.html b/parts/mobile-menu.html deleted file mode 100644 index b7fcdf28..00000000 --- a/parts/mobile-menu.html +++ /dev/null @@ -1,7 +0,0 @@ - -
- -
- - - diff --git a/patterns/drawer-menu.php b/patterns/drawer-menu.php deleted file mode 100644 index 4d043589..00000000 --- a/patterns/drawer-menu.php +++ /dev/null @@ -1,27 +0,0 @@ - - -
- -
- -
- -
- -
- - - -
- diff --git a/patterns/header/header-desktop-style-2.php b/patterns/header/header-desktop-style-2.php index f41b1691..18529fc8 100644 --- a/patterns/header/header-desktop-style-2.php +++ b/patterns/header/header-desktop-style-2.php @@ -41,7 +41,12 @@
- + +
+ +
+
+ diff --git a/patterns/header/header-desktop-style-3.php b/patterns/header/header-desktop-style-3.php index c378a778..4a90feea 100644 --- a/patterns/header/header-desktop-style-3.php +++ b/patterns/header/header-desktop-style-3.php @@ -22,7 +22,12 @@
- + +
+ +
+
+
diff --git a/patterns/header/header-desktop-style-4.php b/patterns/header/header-desktop-style-4.php index 8ad91afd..74770007 100644 --- a/patterns/header/header-desktop-style-4.php +++ b/patterns/header/header-desktop-style-4.php @@ -16,7 +16,12 @@
- + +
+ +
+
+ diff --git a/patterns/header/header-mobile-style-1.php b/patterns/header/header-mobile-style-1.php index ee9a8389..f0a6ea72 100644 --- a/patterns/header/header-mobile-style-1.php +++ b/patterns/header/header-mobile-style-1.php @@ -18,7 +18,12 @@
- + +
+ +
+
+
diff --git a/patterns/header/header-mobile-style-2.php b/patterns/header/header-mobile-style-2.php index c72989ff..31394ff2 100644 --- a/patterns/header/header-mobile-style-2.php +++ b/patterns/header/header-mobile-style-2.php @@ -18,7 +18,12 @@
- + +
+ +
+
+
diff --git a/patterns/header/header-mobile-style-3.php b/patterns/header/header-mobile-style-3.php index 01138674..f9aa7556 100644 --- a/patterns/header/header-mobile-style-3.php +++ b/patterns/header/header-mobile-style-3.php @@ -18,7 +18,12 @@
- + +
+ +
+
+ diff --git a/patterns/header/header-mobile-style-4.php b/patterns/header/header-mobile-style-4.php index f1d6f620..7680a45f 100644 --- a/patterns/header/header-mobile-style-4.php +++ b/patterns/header/header-mobile-style-4.php @@ -18,7 +18,12 @@
- + +
+ +
+
+
diff --git a/patterns/header/header-mobile-style-5.php b/patterns/header/header-mobile-style-5.php index 96908baf..bae8be7d 100644 --- a/patterns/header/header-mobile-style-5.php +++ b/patterns/header/header-mobile-style-5.php @@ -36,7 +36,12 @@ - + +
+ +
+
+
diff --git a/patterns/header/header-mobile-style-6.php b/patterns/header/header-mobile-style-6.php index 7d5b7982..93a0ed7f 100644 --- a/patterns/header/header-mobile-style-6.php +++ b/patterns/header/header-mobile-style-6.php @@ -30,7 +30,12 @@ - + +
+ +
+
+
diff --git a/src/js/front-end/main.js b/src/js/front-end/main.js index ce294d14..ea1ccefe 100644 --- a/src/js/front-end/main.js +++ b/src/js/front-end/main.js @@ -1,4 +1,2 @@ import './menus/comments'; -import './menus/drawer'; -import './menus/mobile'; import './menus/search'; diff --git a/src/js/front-end/menus/drawer.js b/src/js/front-end/menus/drawer.js deleted file mode 100644 index 3ce5b463..00000000 --- a/src/js/front-end/menus/drawer.js +++ /dev/null @@ -1,14 +0,0 @@ -/** - * Internal dependencies. - */ -import { domReady } from '../utils'; -import { createMenu } from './index'; - -domReady( function () { - createMenu( { - menuType: 'drawer-menu', - containerSelector: '.drawer-menu', - toggleSelector: '.drawer-menu__toggle', - contentsSelector: '.drawer-menu__contents', - } ).init(); -} ); diff --git a/src/js/front-end/menus/mobile.js b/src/js/front-end/menus/mobile.js deleted file mode 100644 index 8b418eb2..00000000 --- a/src/js/front-end/menus/mobile.js +++ /dev/null @@ -1,14 +0,0 @@ -/** - * Internal dependencies. - */ -import { domReady } from '../utils'; -import { createMenu } from './index'; - -domReady( function () { - createMenu( { - menuType: 'mobile-menu', - containerSelector: '.header-mobile', - toggleSelector: '.mobile-menu__toggle', - contentsSelector: '.mobile-menu__contents', - } ).init(); -} ); diff --git a/src/scss/overlays/_drawer.scss b/src/scss/overlays/_drawer.scss deleted file mode 100644 index 477267d0..00000000 --- a/src/scss/overlays/_drawer.scss +++ /dev/null @@ -1,26 +0,0 @@ - -@use "../mixins"; - -.drawer-menu { - &__toggle { - &:not(.newspack-icon-close) { - align-items: center; - display: flex; - - .wp-block-button__link { - align-items: center; - display: inline-flex; - gap: var(--wp--preset--spacing--20); - justify-content: center; - - &::before { - background: currentcolor; - content: ""; - height: var(--wp--preset--spacing--40); - mask: url("../../assets/images/icon-menu.svg") 0 0 no-repeat; - width: var(--wp--preset--spacing--40); - } - } - } - } -} diff --git a/src/scss/style.scss b/src/scss/style.scss index 4750dd75..84609ec1 100644 --- a/src/scss/style.scss +++ b/src/scss/style.scss @@ -8,5 +8,4 @@ @use "header.scss"; @use "overlays/base.scss" as overlays; @use "overlays/comments.scss"; -@use "overlays/drawer.scss"; @use "overlays/search.scss"; From e5547c02bf615198d66c754e2e64d1f24a85204f Mon Sep 17 00:00:00 2001 From: Laurel Fulford Date: Tue, 7 Apr 2026 15:45:27 -0700 Subject: [PATCH 2/2] fix: add is style flatten to all the navigation blocks in the overlay block --- patterns/header/header-desktop-style-2.php | 2 +- patterns/header/header-desktop-style-3.php | 2 +- patterns/header/header-desktop-style-4.php | 2 +- patterns/header/header-mobile-style-1.php | 2 +- patterns/header/header-mobile-style-2.php | 2 +- patterns/header/header-mobile-style-3.php | 2 +- patterns/header/header-mobile-style-4.php | 2 +- patterns/header/header-mobile-style-5.php | 2 +- patterns/header/header-mobile-style-6.php | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/patterns/header/header-desktop-style-2.php b/patterns/header/header-desktop-style-2.php index 18529fc8..9ad05812 100644 --- a/patterns/header/header-desktop-style-2.php +++ b/patterns/header/header-desktop-style-2.php @@ -44,7 +44,7 @@
-
+
diff --git a/patterns/header/header-desktop-style-3.php b/patterns/header/header-desktop-style-3.php index 4a90feea..78a92fa3 100644 --- a/patterns/header/header-desktop-style-3.php +++ b/patterns/header/header-desktop-style-3.php @@ -25,7 +25,7 @@
-
+
diff --git a/patterns/header/header-desktop-style-4.php b/patterns/header/header-desktop-style-4.php index 74770007..f7e41e2c 100644 --- a/patterns/header/header-desktop-style-4.php +++ b/patterns/header/header-desktop-style-4.php @@ -19,7 +19,7 @@
-
+
diff --git a/patterns/header/header-mobile-style-1.php b/patterns/header/header-mobile-style-1.php index f0a6ea72..f8cfd023 100644 --- a/patterns/header/header-mobile-style-1.php +++ b/patterns/header/header-mobile-style-1.php @@ -21,7 +21,7 @@
-
+
diff --git a/patterns/header/header-mobile-style-2.php b/patterns/header/header-mobile-style-2.php index 31394ff2..10611112 100644 --- a/patterns/header/header-mobile-style-2.php +++ b/patterns/header/header-mobile-style-2.php @@ -21,7 +21,7 @@
-
+
diff --git a/patterns/header/header-mobile-style-3.php b/patterns/header/header-mobile-style-3.php index f9aa7556..e858c3e6 100644 --- a/patterns/header/header-mobile-style-3.php +++ b/patterns/header/header-mobile-style-3.php @@ -21,7 +21,7 @@
-
+
diff --git a/patterns/header/header-mobile-style-4.php b/patterns/header/header-mobile-style-4.php index 7680a45f..bf62c018 100644 --- a/patterns/header/header-mobile-style-4.php +++ b/patterns/header/header-mobile-style-4.php @@ -21,7 +21,7 @@
-
+
diff --git a/patterns/header/header-mobile-style-5.php b/patterns/header/header-mobile-style-5.php index bae8be7d..b9c10209 100644 --- a/patterns/header/header-mobile-style-5.php +++ b/patterns/header/header-mobile-style-5.php @@ -39,7 +39,7 @@
-
+
diff --git a/patterns/header/header-mobile-style-6.php b/patterns/header/header-mobile-style-6.php index 93a0ed7f..4d8a959a 100644 --- a/patterns/header/header-mobile-style-6.php +++ b/patterns/header/header-mobile-style-6.php @@ -33,7 +33,7 @@
-
+