diff --git a/feature-libs/product-configurator/rulebased/occ/variant/converters/occ-configurator-variant-normalizer.spec.ts b/feature-libs/product-configurator/rulebased/occ/variant/converters/occ-configurator-variant-normalizer.spec.ts index cdd7b911160..d287f67547b 100644 --- a/feature-libs/product-configurator/rulebased/occ/variant/converters/occ-configurator-variant-normalizer.spec.ts +++ b/feature-libs/product-configurator/rulebased/occ/variant/converters/occ-configurator-variant-normalizer.spec.ts @@ -1269,6 +1269,16 @@ describe('OccConfiguratorVariantNormalizer', () => { expect(attributeSSIWithValues.incomplete).toBe(false); }); + it('should set incomplete by single-selection-image type with retract option correctly', () => { + attributeSSIWithValues.selectedSingleValue = + Configurator.RetractValueCode; + occConfiguratorVariantNormalizer.compileAttributeIncomplete( + attributeSSIWithValues + ); + + expect(attributeSSIWithValues.incomplete).toBe(true); + }); + it('should set incomplete by checkbox type correctly', () => { occConfiguratorVariantNormalizer.compileAttributeIncomplete( attributeCheckboxWOValue diff --git a/feature-libs/product-configurator/rulebased/occ/variant/converters/occ-configurator-variant-normalizer.ts b/feature-libs/product-configurator/rulebased/occ/variant/converters/occ-configurator-variant-normalizer.ts index d5d89a05ccf..720fb3fff66 100644 --- a/feature-libs/product-configurator/rulebased/occ/variant/converters/occ-configurator-variant-normalizer.ts +++ b/feature-libs/product-configurator/rulebased/occ/variant/converters/occ-configurator-variant-normalizer.ts @@ -540,6 +540,7 @@ export class OccConfiguratorVariantNormalizer Configurator.UiType.RADIOBUTTON_ADDITIONAL_INPUT, Configurator.UiType.DROPDOWN_ADDITIONAL_INPUT, Configurator.UiType.DROPDOWN, + Configurator.UiType.SINGLE_SELECTION_IMAGE, ]; const inputTypes = [ Configurator.UiType.NUMERIC, @@ -554,8 +555,6 @@ export class OccConfiguratorVariantNormalizer const uiType = attribute.uiType ?? Configurator.UiType.NOT_IMPLEMENTED; if (singleValueTypes.includes(uiType)) { this.compileAttributeIncompleteSingleLevel(attribute); - } else if (uiType === Configurator.UiType.SINGLE_SELECTION_IMAGE) { - this.compileAttributeIncompleteSingleSelectionImage(attribute); } else if (inputTypes.includes(uiType)) { this.compileAttributeIncompleteInputTypes(attribute); } else if (multiValueTypes.includes(uiType)) { @@ -573,13 +572,7 @@ export class OccConfiguratorVariantNormalizer attribute.incomplete = true; } } - protected compileAttributeIncompleteSingleSelectionImage( - attribute: Configurator.Attribute - ): void { - if (!attribute.selectedSingleValue) { - attribute.incomplete = true; - } - } + protected compileAttributeIncompleteInputTypes( attribute: Configurator.Attribute ): void {