Revisions "show changes" setting isn't sticky / gets reset when changing revision

[adamsilverstein]

Description

When using the new revisions UI and turning off "Show Changes" by clicking the eye icon, the setting gets reset as soon as I change to another revision using the top navigation slide.

Step-by-step reproduction instructions

1. create a post with several revisions
2. go to the revisions screen
3. turn off show changes by clicking the eye icon in the upper left
4. navigate to a different revision using the top slider

Expected results: the show changes stays set
Actual results: the setting resets to showing changes

Screenshots, screen recording, code snippet

setting.wont.stick.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[adamsilverstein]

cc: @ellatrix

[Mamaduka]

It looks like changing a revision intentionally resets the "Show changes" state. Though I'm not 100% sure whether it's intentional or a side effect.

gutenberg/packages/editor/src/store/reducer.js

Lines 467 to 474 in 2588c58

	export function showRevisionDiff( state = true, action ) {
	switch ( action.type ) {
	case 'SET_SHOW_REVISION_DIFF':
	return action.showDiff;
	case 'SET_CURRENT_REVISION_ID':
	return true; // reset on enter/exit revisions
	}
	return state;

[adamsilverstein]

It looks like changing a revision intentionally resets the "Show changes" state.

For me it felt unexpected.