BoxControl: remove unused state for icon side#77143
Merged
Conversation
jsnajdr
requested review from
Mamaduka,
ciampo,
manzoorwanijk,
mirka and
youknowriad
|
Size Change: -82 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Apr 8, 2026
|
Flaky tests detected in 13b5e0c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24135701802
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spinoff from ESLint upgrade in #76654 where the linter detected a deeper issue. In this case, an unused
sidestate variable.There is a
[ side, setSide ] = useStatecall where thesidestate is never actually used. The usage was removed in #67626 where a<FlexedBoxControlIcon side={ side }>component was refactored to<InputControl side="all">. But thesidestate was left behind.This PR removes all the irrelevant code, including the
getInitialSidehelper.