From fc4acbd433cc78ceb0808b1fbee6a4c6d300ab96 Mon Sep 17 00:00:00 2001 From: timse201 Date: Fri, 3 Apr 2026 17:54:45 +0200 Subject: [PATCH] fix remove_filter fails to remove import status and modernize array key checks --- .../inc/cli/class-import-plugin-translations.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/cli/class-import-plugin-translations.php b/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/cli/class-import-plugin-translations.php index b3b9066a59..9313a8b231 100644 --- a/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/cli/class-import-plugin-translations.php +++ b/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/cli/class-import-plugin-translations.php @@ -50,12 +50,13 @@ public function __invoke( $args, $assoc_args ) { WP_CLI::error( "Locale not found! [$file]" ); } - $format = gp_array_get( GP::$formats, isset( $assoc_args['format'] ) ? $assoc_args['format'] : 'po', null ); + $format_slug = $assoc_args['format'] ?? 'po'; + $format = gp_array_get( GP::$formats, $format_slug, null ); if ( ! $format ) { WP_CLI::error( "No such format! [$file]" ); } - $set_slug = isset( $assoc_args['set'] ) ? $assoc_args['set'] : 'default'; + $set_slug = $assoc_args['set'] ?? 'default'; $translation_set = GP::$translation_set->by_project_id_slug_and_locale( $project->id, $set_slug, $locale->slug ); if ( ! $translation_set ) { WP_CLI::error( "Translation set not found! [$file]" ); @@ -83,7 +84,7 @@ public function __invoke( $args, $assoc_args ) { // Do the import. $imported = $translation_set->import( $translations ); - remove_filter( 'gp_translation_set_import_status', '__string_status_waiting' ); + remove_filter( 'gp_translation_set_import_status', array( $this, '__string_status_waiting' ) ); remove_filter( 'gp_translation_set_import_over_existing', '__return_false' ); if ( ! empty( $assoc_args['user_id'] ) && isset( $previous_user ) ) {