Skip to content

Commit 1ba335e

Browse files
committed
chore: clean up ICMP TODO list, remove completed items
1 parent 089441e commit 1ba335e

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

src/inet/networklayer/__TODO

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,4 @@
1-
- DONE: refactored ICMP/ICMPv6 error indication propagation (see GitHub issue #1066)
2-
- ICMP pops its own header, creates an Indication with Icmpv4ErrorInd tag (IcmpType type/code/mtu + originalPacket)
3-
- ICMPv6 pops its own header, creates an Indication with Icmpv6ErrorInd tag (Icmpv6Type type/code/mtu + originalPacket)
4-
- IPv4/IPv6 pops the quoted IP header from originalPacket, converts to L3AddressInd/HopLimitInd/etc. tags
5-
- UDP pops the quoted UDP header, adds L4PortInd, looks up socket, forwards the same Indication as UDP_I_ERROR
6-
- QUIC and other transport consumers get the originalPacket with only their own payload, no cross-layer parsing needed
7-
- UDP now sends ICMP errors via Request messages (Icmpv4SendErrorReq / Icmpv6SendErrorReq) through the MessageDispatcher
8-
- TODO: other callers (Ipv4, Ipv6, Ipv4FragBuf, Ipv6FragBuf, Ipv6NeighbourDiscovery) still use direct sendErrorMessage() calls — refactor later
1+
- ICMP error sending: Ipv4, Ipv6, Ipv4FragBuf, Ipv6FragBuf, Ipv6NeighbourDiscovery still use direct sendErrorMessage() calls — refactor to Request messages via MessageDispatcher (like UDP already does with Icmpv4SendErrorReq/Icmpv6SendErrorReq)
92
- implement ICMP rate limiting, see e.g bsd.mod/netinet/ip_icmp.c, badport_bandlim()
103
- ICMP options: stopOnError (bool param), UDPBadPortSendICMP (bool param)
114
- ICMP: shouldn't we unify ICMP and ICMPv6...? at least types and codes?

0 commit comments

Comments
 (0)