Skip to content

[Task]: ensure logging or tracking of 2nd level approval #16136

@mixedpuppy

Description

@mixedpuppy

Description

2nd level approvals need to be fully auditable. Currently we do not log or track who makes those decisions.

https://github.com/mozilla/addons-server/blob/c7adcf372770c4dd60c5954a5f5c0cec89a8be61/src/olympia/reviewers/views.py#L1287

The YES condition doesn't pass the user up for any potential logging. The other conditions do, but I am not certain on how easily auditable this is.

How the user at this stage is tracked should be consistent across these decisions.

Acceptance Criteria

  • logging or user field, consistent across YES/NO/CANCEL

┆Issue is synchronized with this Jira Task

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions