[Bug]: files_external: since NC 33, files_external:notify crashes

[Rudd-O]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

I was doing occ files_external:notify 1 (1 being the mount point to watch) for over a year, and while it wasn't working ideally, it wasn't crashing.

Now it does:

Apr 09 02:13:30 cloud bash[1768]:   [Icewind\SMB\Exception\ConnectionRefusedException]
Apr 09 02:13:30 cloud bash[1768]:                                                       
Apr 09 02:13:30 cloud bash[1768]: files_external:notify [-u|--user USER] [-p|--password PASSWORD] [--path PATH] [--no-self-check] [--dry-run] [--output [OUTPUT]] [--] <mount_id>
Apr 09 02:13:30 cloud bash[1775]: In SMB.php line 67:
Apr 09 02:13:30 cloud bash[1775]:                                
Apr 09 02:13:30 cloud bash[1775]:   user or password is not set
Apr 09 02:13:30 cloud bash[1775]:                          

Steps to reproduce

1. Attempt to monitor external file share with the command listed above.

Expected behavior

Monitor just stands there and works.

Nextcloud Server version

33

Operating system

RHEL/CentOS

PHP engine version

PHP 8.4

Web server

Nginx

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 31 to 32)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

{
    "system": {
        "loglevel": 1,
        "log_type": "file",
        "log_type_audit": "file",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "updatechecker": false,
        "check_for_working_htaccess": false,
        "asset-pipeline.enabled": false,
        "assetdirectory": "\/var\/lib\/nextcloud",
        "preview_libreoffice_path": "\/usr\/bin\/libreoffice",
        "apps_paths": [
            {
                "path": "\/usr\/share\/nextcloud\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/lib\/nextcloud\/apps",
                "url": "\/apps-appstore",
                "writable": true
            }
        ],
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "cloud.rudd-o.com"
        ],
        "dbtype": "mysql",
        "version": "33.0.1.2",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "htaccess.RewriteBase": "\/",
        "mail_smtpmode": "smtp",
        "mail_smtpsecure": "tls",
        "mail_sendmailmode": "smtp",
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpauth": 1,
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "587",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "maintenance": false,
        "enabledPreviewProviders": [
            "OC\\Preview\\BMP",
            "OC\\Preview\\GIF",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\Krita",
            "OC\\Preview\\MarkDown",
            "OC\\Preview\\MP3",
            "OC\\Preview\\OpenDocument",
            "OC\\Preview\\PNG",
            "OC\\Preview\\TXT",
            "OC\\Preview\\XBitmap",
            "OC\\Preview\\Movie",
            "OC\\Preview\\PDF"
        ],
        "preview_max_x": 1024,
        "preview_max_y": 1024,
        "theme": "",
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "https:\/\/cloud.rudd-o.com",
        "app_install_overwrite": [
            "news",
            "caniupdate",
            "inventory",
            "files_markdown",
            "mindmap_app",
            "facerecognition",
            "files_scripts",
            "otpmanager",
            "files_mindmap"
        ],
        "memcache.local": "\\OC\\Memcache\\APCu",
        "default_phone_region": "CH",
        "maintenance_window_start": 4,
        "memories.db.triggers.fcu": true,
        "memories.exiftool_no_local": true,
        "memories.vod.path": "\/var\/lib\/nextcloud\/apps\/memories\/bin-ext\/go-vod-amd64",
        "memories.vod.ffmpeg": "\/usr\/bin\/ffmpeg",
        "memories.vod.ffprobe": "\/usr\/bin\/ffprobe",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "memcache.distributed": "\\OC\\Memcache\\Redis"
    }
}

List of activated Apps

Enabled:
  - activity: 6.0.0-dev.0
  - app_api: 33.0.0
  - bruteforcesettings: 6.0.0-dev.0
  - calendar: 6.2.2
  - circles: 33.0.0
  - cloud_federation_api: 1.17.0
  - comments: 1.23.0
  - contacts: 8.4.3
  - contactsinteraction: 1.14.1
  - dashboard: 7.13.0
  - dav: 1.36.0
  - deck: 1.17.0
  - event_update_notification: 2.8.0
  - facerecognition: 0.9.70
  - federatedfilesharing: 1.23.0
  - federation: 1.23.0
  - files: 2.5.0
  - files_downloadlimit: 5.1.0-dev.0
  - files_external: 1.25.1
  - files_mindmap: 0.0.33
  - files_pdfviewer: 6.0.0-dev.0
  - files_reminders: 1.6.0
  - files_scripts: 4.1.0
  - files_sharing: 1.25.2
  - files_trashbin: 1.23.0
  - files_versions: 1.26.0
  - fileslibreofficeedit: 2.0.1
  - firstrunwizard: 6.0.0-dev.0
  - gpoddersync: 3.16.0
  - inventory: 0.1.4
  - logreader: 6.0.0
  - lookup_server_connector: 1.21.0
  - memories: 8.0.1
  - news: 28.1.0
  - nextcloud_announcements: 5.0.0
  - notifications: 6.0.0
  - oauth2: 1.21.0
  - password_policy: 5.0.0-dev.0
  - photos: 6.0.0-dev.0
  - polls: 8.6.3
  - previewgenerator: 5.13.0
  - privacy: 5.0.0-dev.0
  - profile: 1.2.0
  - provisioning_api: 1.23.0
  - recognize: 11.0.1
  - related_resources: 4.0.0-dev.0
  - richdocuments: 10.1.2
  - serverinfo: 5.0.0-dev.0
  - settings: 1.16.0
  - sharebymail: 1.23.0
  - side_menu: 5.3.0
  - support: 5.0.0
  - survey_client: 5.0.0-dev.0
  - systemtags: 1.23.0
  - tables: 2.0.1
  - tasks: 0.17.1
  - text: 7.0.0-dev.3
  - theming: 2.8.0
  - twofactor_backupcodes: 1.22.0
  - twofactor_totp: 15.0.0-dev.0
  - updatenotification: 1.23.0
  - user_status: 1.13.0
  - viewer: 6.0.0-dev.0
  - weather_status: 1.13.0
  - webhook_listeners: 1.5.0
  - whiteboard: 1.5.7
  - workflow_ocr: 1.33.0
  - workflow_script: 4.0.0
  - workflowengine: 2.15.0
Disabled:
  - admin_audit: 1.23.0 (installed 1.20.0)
  - encryption: 2.21.0
  - files_rightclick: 0.15.1 (installed 1.6.0)
  - otpmanager: 1.1.2 (installed 1.1.2)
  - recommendations: 6.0.0-dev.0 (installed 3.0.0)
  - suspicious_login: 11.0.0-dev.0
  - testing: 1.23.0
  - twofactor_nextcloud_notification: 7.0.0
  - uppush: 2.4.0 (installed 2.4.0)
  - user_ldap: 1.24.0

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

[joshtrichards]

What authentication/credentials mode are you using for that External Storage mount?

And what version of Nextcloud did it last work on?

The last potentially relevant change in this area I see was way back in v29.

[Rudd-O]

It was working fine in NC32.

Each SMB mount is set up in the mode where it has an individual user and password.

[Rudd-O]

Got a traceback:

 user  ~  occ files_external:notify -vvv -- 3
gencache_init: Failed to create directory: /usr/share/httpd/.cache/samba - Permission denied
gencache_init: Failed to create directory: /usr/share/httpd/.cache/samba - Permission denied
gencache_init: Failed to create directory: /usr/share/httpd/.cache/samba - Permission denied

In Connection.php line 56:
                                                      
  [Icewind\SMB\Exception\ConnectionRefusedException]  
                                                      

Exception trace:
  at /usr/share/nextcloud/3rdparty/icewind/smb/src/Wrapped/Connection.php:56
 Icewind\SMB\Wrapped\Connection->clearTillPrompt() at /usr/share/nextcloud/3rdparty/icewind/smb/src/Wrapped/Share.php:113
 Icewind\SMB\Wrapped\Share->getConnection() at /usr/share/nextcloud/3rdparty/icewind/smb/src/Wrapped/Share.php:445
 Icewind\SMB\Wrapped\Share->notify() at /usr/share/nextcloud/3rdparty/icewind/smb/src/Native/NativeShare.php:362
 Icewind\SMB\Native\NativeShare->notify() at /usr/share/nextcloud/apps/files_external/lib/Lib/Storage/SMB.php:732
 OCA\Files_External\Lib\Storage\SMB->notify() at /usr/share/nextcloud/apps/files_external/lib/Command/Notify.php:92
 OCA\Files_External\Command\Notify->execute() at /usr/share/nextcloud/3rdparty/symfony/console/Command/Command.php:326
 Symfony\Component\Console\Command\Command->run() at /usr/share/nextcloud/core/Command/Base.php:220
 OC\Core\Command\Base->run() at /usr/share/nextcloud/3rdparty/symfony/console/Application.php:1083
 Symfony\Component\Console\Application->doRunCommand() at /usr/share/nextcloud/3rdparty/symfony/console/Application.php:324
 Symfony\Component\Console\Application->doRun() at /usr/share/nextcloud/3rdparty/symfony/console/Application.php:175
 Symfony\Component\Console\Application->run() at /usr/share/nextcloud/lib/private/Console/Application.php:187
 OC\Console\Application->run() at /usr/share/nextcloud/console.php:92
 require_once() at /usr/share/nextcloud/occ:33

files_external:notify [-u|--user USER] [-p|--password PASSWORD] [--path PATH] [--no-self-check] [--dry-run] [--output [OUTPUT]] [--] <mount_id>

[Rudd-O]

Note that the mounts work perfectly! I can browse and see stuff, edit files there, everything just works -- except, of course, folders aren't updated until they are accessed.