Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
colinswinney
commented
Apr 2, 2026
Contributor
Author
colinswinney
left a comment
There was a problem hiding this comment.
Training Lessons Review (Block-Based Themes)
Spelling Errors
- index.md ~line 91:
"a approximately 90 persons"→"approximately 90 persons" - index.md ~line 99:
"comma seperated list"→"comma separated list" - 01-overview.md ~line 119:
"you don't wite any CSS"→"write" - 03-site-editor.md ~line 96:
"Create Bock Theme"→"Create Block Theme" - 08-editor-controls.md ~line 334:
"re-enforce"→"reinforce" - 08-editor-controls.md ~line 340:
"uniqiue"→"unique" - 09-archive-templates-and-cards.md ~line 70:
"WP heirarchy"→"hierarchy"
Grammar / Missing Words
- 03-site-editor.md ~line 46:
"This is due to 'Inserter: false' property in the files metadata."— missingthebefore property, andfilesshould be possessive (file's) - 03-site-editor.md ~line 46:
"Set it true"→"Set it to true"and"display it the editor"→"display in the editor" - 13-interactivity-api.md ~line 325:
"Computed state ('get' properties) automatically updates"→"automatically update"(plural)
Contradictory / Stale Content
- 10-block-bindings.md ~line 366: Takeaway says "Only Image, Paragraph, Heading, and Button support bindings today" but the lesson's own table (line 200-208) lists 7 blocks and the WP 7.0 section explains any block can opt in via filter. This takeaway needs updating.
- 10-block-bindings.md ~line 349: Files changed table marks
single-tenup-movie.htmlandsingle-tenup-person.htmlas New, but they were created as placeholders in Lesson 3. Should be Modified or Replaced.
Unfinished Editorial Note
- 12-custom-blocks.md ~lines 206-209: The
:::warningblock reads like an internal author note:"Is it worth mentioning once more here that..."This should be rewritten as student-facing content or removed.
Count Mismatch
- 07-content-model.md ~line 163: Says "Movie (9 fields)" but only 8 field names are listed (
imdb_id,mpa_rating,plot,release_year,runtime,viewer_rating,viewer_rating_count,trailer_id).
Numbering Issues
- 05-styles.md ~line 379: Step numbered
1.but should be4.(follows steps 1, 2, 3 in the hands-on section). Markdown ordered list restarts. - 11-block-extensions.md ~line 87: Section header jumps from
### 2.to### 4.with no### 3.
Systemic: Double-Slash Image Paths
~30+ image paths across all lessons use ../../static//img/ (double slash). While most renderers tolerate this, it should be ../../static/img/. Occurs in every lesson file and index.md. One correct single-slash path exists at 01-overview.md line 103, confirming the double-slash is unintentional.
Inconsistency: render.php vs markup.php
- Lesson 12 uses
render.phpfor block render files - Lesson 13 uses
markup.phpfor the rate-movie block
Both are valid (block.json can point to any file), but the inconsistency may confuse students who expect a convention.
Parameter Naming in Lesson 06
- 06-render-filters-and-block-styles.md lines 46, 73: The
render_blockfilter callback names its parameters$block(parsed block array) and$parsed_block(WP_Block instance). The names suggest the opposite of what they actually are. Consider renaming to$blockand$block_instanceor$block_arrayand$wp_blockfor clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds a complete lesson outline to the Block Based Theme Training module.
Closing #