Open
Conversation
Fixes 360Conferences#26: When loading the speaker list, avatar images would pop in late, or have a "ghost" from the previous bind. The viewholder was requesting a `downloadUrl` for each avatar on bind. This switches to using coroutines to map the avatar download url into the `Speaker` model itself. Doing this lets the recycler have all the data it needs to bind its viewholders.
JakeWharton
reviewed
Apr 12, 2018
| }) | ||
| override suspend fun getAvatarUri(speaker: Speaker) = suspendCoroutine<String> { c -> | ||
| val id = speaker.id ?: "" | ||
| if (id.isEmpty()) { |
Contributor
There was a problem hiding this comment.
can just be id == null to get rid of the ?: above
rharter
requested changes
Apr 12, 2018
Collaborator
rharter
left a comment
rharter
left a comment
There was a problem hiding this comment.
Overall looks good, I think we're ready to coroutine all the things ;)
| val github: String? = null, | ||
| val bio: String? = null) { | ||
| val bio: String? = null, | ||
| val downloadUrl: String? = null) { |
Collaborator
There was a problem hiding this comment.
For clarity could you please rename this to something like avatarUrl?
burntcookie90
force-pushed
the
vr/speaker-list-avatar-fix
branch
from
8e54b87 to
987a1fa
Compare
Contributor
Author
|
All ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26