Updated info page animation#36
Open
gilgoldzweig wants to merge 3 commits into360Conferences:masterfrom
Open
Conversation
rharter
requested changes
Mar 7, 2020
Collaborator
rharter
left a comment
rharter
left a comment
There was a problem hiding this comment.
Sorry for the delay, I'm sure you can imagine things have been busy with the reschedule.
Thanks for the contribution! I think some of these changes don't handle different screen sizes. Also, I noticed a bit of padding between the list and the toolbar in both states. Not sure if that comes from the change in inset handling.
| } | ||
|
|
||
| binding.inset.doOnApplyWindowInsets { view, insets, initialState -> | ||
| binding.inset.doOnApplyWindowInsets { _, insets, _ -> |
Collaborator
There was a problem hiding this comment.
This change looks like you're now setting the height of the wrong view. The height was being set on the inset view, not the fragment's view.
| android:layout_height="wrap_content" | ||
| android:text="Roboto" | ||
| android:gravity="start|center_vertical" | ||
| android:text=" app is open souce," |
Collaborator
There was a problem hiding this comment.
These were intentionally broken up so the text would still flow on smaller devices (and larger ones). Does this mitigate that in some way?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.