Skip to content

Maintain list state after config change#37

Open
josephkreiser wants to merge 3 commits into360Conferences:masterfrom
josephkreiser:maintain-list-state-after-config-change
Open

Maintain list state after config change#37
josephkreiser wants to merge 3 commits into360Conferences:masterfrom
josephkreiser:maintain-list-state-after-config-change

Conversation

@josephkreiser
Copy link
Copy Markdown

  • Move setting of pager adapter so that list fragment state is restored after config change

    • After a config change (such as screen rotation), a ViewPager2's state is restored when its adapter is set. If the adapter is set before the backing data is set, then each of the ViewPager2's page Fragment's states won't be restored as expected. By moving the setting of the adapter after the adapter's data is set, it allows the currently selected tab to be restored as well as the scroll position of the RecyclerViews in the list Fragments.
  • Set the current tab to today only once on startup so that after a config change, it won't change the user's currently selected tab

  • Fix date string

… after config change

After a config change (such as screen rotation),
a ViewPager2's state is restored when its adapter is set.  If the adapter is set before
the backing data is set, then each of the ViewPager2's page Fragment's states won't
be restored as expected.  By moving the setting of the adapter after the adapter's
data is set, it allows the currently selected tab to be restored as well as the scroll
position of the RecyclerViews in the list Fragments.
…fig change, it won't change the user's currently selected tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant