Closed
Conversation
2 tasks
Owner
Author
|
For 1.2.0, we'll need to find a way to atomically update the database schema without affecting other running LibertyBans instances. |
A248
force-pushed
the
issue-343-longer-scopes
branch
3 times, most recently
from
fbe9d8b to
dbca962
Compare
* Move scope length check to insertion only at application level. This gives flexibility to update the database schema in a later version, including views, to have a longer length (255). This change therefore prepares forward compatibility in 1.1.x. * This tells us what will be needed for version 1.2.0. Perhaps an abandonment of views, or their temporary deletion? We'll have to find a solution that prevents intermediate drops. If transactional DDL exists, maybe we can use it.
A248
force-pushed
the
issue-343-longer-scopes
branch
from
dbca962 to
7ed7741
Compare
Owner
Author
|
Changed into the 1.1.x-maintenance branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares forward compatibility with 1.2.0, which is when we'll allow longer scope lengths at the database level. For now, the 32-scope length is checked at insertion time only and in the database schema, but future schema changes will allow retrieving scopes up to length 1024.
*Testing
An integration test is used to simulate operation of LibertyBans 1.1.x alongside a database that has already been upgraded to 1.2.0 (perhaps due to other LibertyBans instances).
Due to a bug in JUnit 5, we have to use method parameters and not constructor parameters in the forward compatibility integration test.