feat: make Pulp concurrent request limit configurable, raise to 20#1206
Open
andrewlukoshko wants to merge 1 commit intomasterfrom
Open
feat: make Pulp concurrent request limit configurable, raise to 20#1206andrewlukoshko wants to merge 1 commit intomasterfrom
andrewlukoshko wants to merge 1 commit intomasterfrom
Conversation
The hardcoded PULP_SEMAPHORE of 5 serializes most parallel Pulp operations. Errata releases (10+ repos x modify + publish), build artifact uploads (5-20 create_entity calls), and release planning all queue far more than 5 concurrent requests. Add a pulp_semaphore_limit setting to config (configurable via PULP_SEMAPHORE_LIMIT env var) with a default of 20. Scripts that override PULP_SEMAPHORE directly continue to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pulp_semaphore_limitsetting toconfig.py(default 20, configurable viaPULP_SEMAPHORE_LIMITenv var)asyncio.Semaphore(5)inpulp_client.pywithasyncio.Semaphore(settings.pulp_semaphore_limit)PULP_SEMAPHOREdirectly (errata_fix_script, backup_beta_repos, etc.) continue to work unchangedThe previous limit of 5 was a significant bottleneck for parallel Pulp operations: errata releases (10+ repos), build artifact uploads (5-20 artifacts), and release planning all queue far more concurrent requests.
Test plan
PULP_SEMAPHORE_LIMITenv var override workstests/fixtures/pulp.py:31) still worksPULP_SEMAPHORE = asyncio.Semaphore(10)) still works