-
Notifications
You must be signed in to change notification settings - Fork 58
feat(components): addToolbarBackButton util in newspack-components #4619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkoo
wants to merge
6
commits into
trunk
Choose a base branch
from
feat/editor-back-button
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−2
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b09bbe5
feat(editor-back-button): reusable function to add a back button to t…
dkoo c05ada6
feat: addToolbarBackButton util in newspack-components
dkoo 425fd17
Update src/content-gate/editor/editor.js
dkoo 3189010
refactor: copilot feedback
dkoo fb7497d
fix: only show custom back button when not in fullscreen mode
dkoo b868ccb
chore: add missing new style.scss
dkoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
packages/components/src/utils/editor-toolbar-back-button.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| /** | ||
| * A utility to add a back button to the editor toolbar. | ||
| */ | ||
|
|
||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { __ } from '@wordpress/i18n'; | ||
| import { Button, Tooltip } from '@wordpress/components'; | ||
| import { subscribe } from '@wordpress/data'; | ||
| import domReady from '@wordpress/dom-ready'; | ||
| import { createRoot } from '@wordpress/element'; | ||
| import { arrowUpLeft } from '@wordpress/icons'; | ||
|
|
||
| const WRAPPER_ID = 'newspack-editor-toolbar-wrapper'; | ||
|
|
||
| const ToolbarButton = ( { href }: { href: string } ) => ( | ||
| <Tooltip text={ __( 'Go back', 'newspack-plugin' ) }> | ||
| <Button icon={ arrowUpLeft } href={ href } style={ { marginRight: '24px' } } /> | ||
dkoo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| </Tooltip> | ||
| ); | ||
|
|
||
| export const addToolbarBackButton = ( href: string = '' ) => | ||
| subscribe( () => { | ||
dkoo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| if ( document.getElementById( WRAPPER_ID ) ) { | ||
| return; | ||
| } | ||
dkoo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| domReady( () => { | ||
| const toolbar = document.querySelector( '.editor-header__toolbar' ); | ||
| if ( ! toolbar ) { | ||
| return; | ||
| } | ||
|
|
||
| const wrapper = document.createElement( 'div' ); | ||
| wrapper.id = WRAPPER_ID; | ||
| toolbar.prepend( wrapper ); | ||
dkoo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| const root = createRoot( wrapper ); | ||
| root.render( <ToolbarButton href={ href } /> ); | ||
| } ); | ||
| } ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.