-
Notifications
You must be signed in to change notification settings - Fork 58
feat(reader-activation): frontend registration API for integrations #4626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jason10lee
wants to merge
42
commits into
trunk
Choose a base branch
from
feat/integrations-reader-registration
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 19 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
0250b2a
feat: initial reader registration API rollup from working branch
jason10lee 96516b2
docs: annotated new functions with type hints
jason10lee e38a94f
fix: centralize, normalize definition of `$referer`
jason10lee ea9af30
fix: use returned status rather than hardcoded value
jason10lee e0b2de8
test: annotate with group like we do elsewhere for isolated testing
jason10lee d206c54
docs: note to self about parameterizing `verify_captcha()`
jason10lee f143df2
docs: note about better mitigating attacks
jason10lee 4d2fcd4
docs: note potential disclosure and mitigation path
jason10lee 3200cc0
fix: merge into existing `reader` now that we are out of POC
jason10lee a70d5ff
fix: condition reCAPTCHA v3 actions on their `ready()`
jason10lee ea549c1
style: explicit fallback for `wp_parse_url()` as suggested by Copilot
jason10lee 18de923
fix: make endpoint available only when RAS is enabled, per Copilot
jason10lee 689107b
test: properly tear down our new routes
jason10lee 56ba6ea
feat: localize reCAPTCHA site key and version for both v2 and v3
jason10lee 60b0e77
feat: add reCAPTCHA v2 invisible support to register()
jason10lee f224df8
fix: move grecaptcha.execute inside try block to prevent Promise leak
jason10lee 9cfcc30
fix: add isolated flag to v2 invisible widget to prevent interference
jason10lee 8fd1a17
fix: add 30s timeout to v2 invisible token acquisition to prevent hang
jason10lee 334c6d0
docs: note potential concurrent-call guard for v2 invisible token
jason10lee dd4c46b
fix: gracefully reject calls if essential config is missing
jason10lee 9941580
docs: potential future directions for rate limiting
jason10lee 4fbb990
fix: address potential race condition on multiple registrations with …
jason10lee be59918
fix: ensure idempotency by making sure callers get current reader dat…
jason10lee 22c87af
fix: condition config output on RAS
jason10lee 56e699f
fix: use server-side email, not submitted email, for logged-in users
jason10lee 099a109
fix: reject Promise and provide helpful error if reCAPTCHA not happy
jason10lee 0ec69a2
fix: move reCAPTCHA behind rate limiting to protect metered service f…
jason10lee 4d88837
test: regression test for race condition
jason10lee e6d6216
test: test our referrer normalization
jason10lee 59a2242
test: regression test reCAPTCHA at the filter level, as mocking the A…
jason10lee 7fb7989
test: verify registry gating on RAS
jason10lee 4fbf3e0
test: verify stability of our integration keys
jason10lee e6826ff
refactor: extract Reader_Registration class from Reader_Activation
jason10lee 4341739
refactor: delegate frontend registration to Reader_Registration class
jason10lee b224401
test: update references to Reader_Registration class
jason10lee b0074c0
fix: add `use` statements for clarity
jason10lee 2b4d04f
feat: add overridable registration key methods to Integration base class
jason10lee 6aba746
feat: delegate key generation and validation to Integration instances
jason10lee c3ad735
test: add tests for Integration-based key generation and validation
jason10lee 9e48c6e
test: register integration within test because apparently PHPUnit doe…
jason10lee 09236d8
docs: make it clear that overriding the validation step means writing…
jason10lee 5a28ab9
Merge branch 'trunk' into feat/integrations-reader-registration
jason10lee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.