feat(block-theme): move co-authors RSS feed code to the Newspack Plugin#4629
Open
laurelfulford wants to merge 3 commits intotrunkfrom
Open
feat(block-theme): move co-authors RSS feed code to the Newspack Plugin#4629laurelfulford wants to merge 3 commits intotrunkfrom
laurelfulford wants to merge 3 commits intotrunkfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a Newspack-side integration for the Co-Authors Plus plugin so RSS/feed author output can include all co-authors, and wires that integration into the main plugin include list.
Changes:
- Added a
Newspack\RSS_Feedintegration that filtersthe_authorin feed contexts to output co-authors. - Included the new integration file in
Newspack::includes()so it loads with other Co-Authors Plus integrations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
includes/plugins/co-authors-plus/class-rss-feed.php |
Introduces a feed-specific the_author filter to return co-author output in feeds. |
includes/class-newspack.php |
Loads the new Co-Authors Plus RSS integration during plugin includes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR and Automattic/newspack-theme#2671 remove functionality that adds Co-Authors to the RSS feed from the classic theme, and adds it to the Newspack Plugin. This makes it available regardless of theme used.
Closes NPPD-1345
How to test the changes in this Pull Request:
<dc:creator>in the posts you created.Other information: