Expand Linear Release path filters for Creators#109864
Expand Linear Release path filters for Creators#109864robertbpugh wants to merge 3 commits intotrunkfrom
Conversation
Add missing Reader paths (state, data, lib, conversation/follow blocks) and Newsletter paths (settings, onboarding flow, importer, subscriptions). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
matticbot
added
the
[Status] Needs Review
There was a problem hiding this comment.
Pull request overview
Expands the GitHub Actions path filters for the Creators Linear Release sync workflow so merges to trunk trigger the release pipeline for additional Reader, Newsletter, and Subscriptions code paths.
Changes:
- Broadened Reader-related workflow triggers to include state, data, lib, and additional blocks.
- Added Newsletter settings, onboarding flow, and importer paths to the workflow triggers.
- Added Subscriptions landing and subscriber/data-store paths to the workflow triggers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - 'client/reader/**' | ||
| - 'client/blocks/reader-*/**' | ||
| # Newsletter | ||
| - 'client/blocks/conversation-*/**' |
There was a problem hiding this comment.
client/blocks/conversation-*/** does not match the existing client/blocks/conversations/** directory (plural). As a result, changes to the Conversations block won’t trigger this workflow. Add an explicit client/blocks/conversations/** path (or widen the glob) to cover that directory too.
| - 'client/blocks/conversation-*/**' | |
| - 'client/blocks/conversation-*/**' | |
| - 'client/blocks/conversations/**' |
| # Subscriptions | ||
| - 'client/landing/subscriptions/**' | ||
| - 'packages/subscriber/**' | ||
| - 'packages/data-stores/src/subscriber/**' | ||
| - 'packages/data-stores/src/newsletter-categories/**' |
There was a problem hiding this comment.
packages/data-stores/src/newsletter-categories/** is listed under the # Subscriptions section, but the path name suggests it’s Newsletter-related. Consider moving it under the Newsletter section or updating the section comment so future maintainers don’t misinterpret the ownership/scope.
| # Subscriptions | |
| - 'client/landing/subscriptions/**' | |
| - 'packages/subscriber/**' | |
| - 'packages/data-stores/src/subscriber/**' | |
| - 'packages/data-stores/src/newsletter-categories/**' | |
| - 'packages/data-stores/src/newsletter-categories/**' | |
| # Subscriptions | |
| - 'client/landing/subscriptions/**' | |
| - 'packages/subscriber/**' | |
| - 'packages/data-stores/src/subscriber/**' |
Owned by Avalon team (Titan/GSuite), not Creators. Newsletter-specific paths are already covered separately. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
@copilot apply changes based on the comments in this thread |
Copilot caught that conversation-*/** misses the plural conversations/ directory. Also moved newsletter-categories under the Newsletter section. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Both changes from that review thread have been applied in commit
|
Part of #109467
Proposed Changes
Why are these changes being made?
The initial workflow in #109467 only covered top-level Reader and Newsletter directories. Changes to Reader Redux state (
client/state/reader/), the subscriptions landing page (client/landing/subscriptions/), newsletter settings (client/my-sites/site-settings/settings-newsletter/), and other Creators-owned paths were not triggering releases.Intentionally excluded paths owned by other teams (stats, memberships/payments, Titan email, notification settings).
Testing Instructions
Pre-merge Checklist
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com