Open
Conversation
Once OmnibarHelpCenter has been opened the first time, keep the inner HelpCenter mounted instead of unmounting it on close. Unmounting tore down the Zendesk Smooch iframe mid-request and surfaced "TypeError: Failed to fetch" in the console (DOTMSD-1197). The lazy chunk download is still deferred until the first open. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Writing to ref.current during render is discouraged outside of lazy initialization. Switch to useState with React's documented "adjust state during render" pattern, which expresses the one-way latch idiomatically. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
matticbot
added
the
[Status] Needs Review
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist