Skip to content

MSD: Add sidebar top padding when no logo #109880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
p-jackson merged 1 commit into from
Apr 8, 2026
+4 −0
Merged

MSD: Add sidebar top padding when no logo #109880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions client/dashboard/app/responsive-sidebar/sidebar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
overflow-y: auto;
}

.dashboard-responsive-sidebar__sidebar:not( :has( > .dashboard-responsive-sidebar__logo ) ) {
padding-block-start: $grid-unit-30;
Copy link
Copy Markdown
Member Author

@p-jackson p-jackson Apr 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took this padding number from the existing flex gap value used between the horizontal rule and the nav items.

Image

But it does mean that it's not even: the top and left/right paddings are different.

Image

Not blocking I don't think, but do you have an opinion about how much padding to use between the omnibar and the first nav items when there's no logo @lucasmendes-design?

}

.dashboard-responsive-sidebar__logo {
padding: 14px $grid-unit-30 + 2px;
border-block-end: 1px solid var( --dashboard-header__border-color );
Expand Down
Loading