Skip to content

A4A-2379: Enable lead matching pilot for selected agencies#109891

Open
cleacos wants to merge 3 commits intotrunkfrom
a4a-2379/enable-lead-matching-pilot-for-selected-agencies
Open

A4A-2379: Enable lead matching pilot for selected agencies#109891
cleacos wants to merge 3 commits intotrunkfrom
a4a-2379/enable-lead-matching-pilot-for-selected-agencies

Conversation

@cleacos
Copy link
Copy Markdown
Contributor

@cleacos cleacos commented Apr 8, 2026

Part of A4A-2379

Proposed Changes

  • Add a pilot allowlist for the a4a-partner-directory-lead-matching visibility gate.
  • Keep the global config feature flag as the top-level override.
  • Use the same agency-scoped visibility check for the partner-directory menu item and route guard.
  • Add focused test coverage for the helper.

Why are these changes being made?

  • Lead matching should stay disabled by default in shared environments while selected pilot
    agencies get access to the feature.
  • The existing implementation only supports a global flag, which is too broad for the pilot
    rollout.

Testing Instructions

  • Run:
    yarn test-client client/a8c-for-agencies/sections/partner-directory/lib/test/lead-matching-visibility.test.ts --runInBand
  • With the global flag disabled, verify agencies 232667176, 251102500, 234036126,
    234278359, and 232640028 can access /partner-directory/lead-matching and see the menu
    entry.
  • Verify a non-pilot agency still does not see the menu item and is redirected away from the
    lead-matching route.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@cleacos cleacos self-assigned this Apr 8, 2026
@cleacos cleacos requested a review from a team April 8, 2026 15:47
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 8, 2026
@cleacos cleacos marked this pull request as ready for review April 8, 2026 15:48
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Apr 8, 2026

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug a4a-2379/enable-lead-matching-pilot-for-selected-agencies on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants