Unify site launch celebration modal#109896
Merged
Conversation
matticbot
added
[Status] Needs Review
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
…a single instance is rendered
zaguiini
force-pushed
the
datsci-1228-maintain-replace-celebrate-launch-modal
branch
from
5c912cc to
373d161
Compare
zaguiini
changed the title
zaguiini
changed the title
github-actions
bot
removed
the
[Status] Needs Review
| as={ Button } | ||
| variant="primary" | ||
| disabled={ isLoading || launchSiteMutation.isPending } | ||
| isBusy={ launchSiteMutation.isPending } |
Contributor
There was a problem hiding this comment.
I think this changed caused a console warning. It's flowing through to the DOM element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DATSCI-1228.
Proposed Changes
Abstracts the site launch celebration (Calypso & MSD) into a single modal implemented within MSD for easier maintenance. Almost no changes were necessary to the MSD modal; it was a matter of replacing the usage with a wrapper component.
The heavier changes are within Calypso. We had a couple of problems:
/themes/%spage by clicking the masterbar did not open the modalTo fix all problems, we had to hoist the
<CelebrationModal />instantiation as high as possible, even higher than the masterbar, so it's now included within the layout.That would mean we'd load the modal for every Calypso request, but we implemented a guard mechanism that checks whether the site the user is browsing (or last browsed) is unlaunched, or whether the URL includes the
celebrateLaunch=trueparam, so we only load the modal chunk when needed.Testing Instructions
Test cases
Modify
client/layout/masterbar/masterbar-launch-button.tsxandclient/my-sites/customer-home/cards/launchpad/pre-launch.tsxso it loads thecalypso_launch_button_experiment_test_20260319_4experiment.Don't forget to clear local storage to get the most up-to-date value coming from Explat.
Assign yourself to the variations below using the bookmarklet, then follow the instructions.
gated_site_launchexperience, and you should see the celebration modal when you're redirected backungated_site_launchexperience, and you should see the celebration modal immediately after launchingTest instances
Masterbar
In Calypso and Calypso Dashboard, after selecting a site.
Pre-launch Launchpad in Calypso My Home
Enter
/home/%swith an unlaunched site.Focused Launchpad
We have it disabled, so you'll need to hardcode
truehere: 3ae7f-pb