This repository was archived by the owner on Jun 22, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Issue #2899254: Integrate editorial search with Search API module #434
Open
chrfritsch
wants to merge
193
commits into
8.x-2.x
Choose a base branch
from
feature/2899254-integrate_editorial_search_with_search_api
base: 8.x-2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
193 commits
Select commit
Hold shift + click to select a range
20c502c
Add search_api and facet module
chrfritsch 8389d0d
Add VBO and index+server
chrfritsch c192fbf
Add facets
chrfritsch 49dfacc
Use facets dev
chrfritsch d266358
Add toolbar
chrfritsch b37766a
Style content overview and remove toolbar block
chrfritsch 5df7e38
Add db command patch
chrfritsch 5b87def
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 5641d3d
Apply patches before dump creation
chrfritsch f938bec
Try to fix config
chrfritsch fd6ad2d
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 9f8ddb5
Fix config
chrfritsch 17febb7
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
dbosen 993c89b
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 1e7a320
Merge branch 'feature/2899254-integrate_editorial_search_with_search_…
chrfritsch 0b7fed7
WIP
chrfritsch 41a566c
Fix cs
chrfritsch 5ae3f8f
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch f91dca3
WIP
chrfritsch 1b9a54d
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 74bdf5d
WIP
chrfritsch d9fc9ec
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 87b1690
WIP
chrfritsch 3d49485
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 859bba8
WIP
chrfritsch 2c8cdf7
Merge branch 'feature/2899254-integrate_editorial_search_with_search_…
chrfritsch 12f2876
Stable versions
chrfritsch f7d9c6a
Finalize content search
chrfritsch ee3fe89
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 716f951
Update media view
chrfritsch 7f235a8
Add media facets
chrfritsch 917b2d0
Use search api in entity browser
chrfritsch ba7cac9
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 9393f66
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 4206ebf
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 2f6138b
Update modules and patches
chrfritsch a3386b7
Fix makefile
chrfritsch 6d721a2
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 081b6eb
Add missing configs
chrfritsch 6033735
Add local tasks to content view
chrfritsch 9401202
Remove on all paths
chrfritsch a805017
Fix CS
chrfritsch 3ab390b
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch e8b3e3b
Use config_selector for content view replacement
chrfritsch b4c1f1e
Use config_selector for media search
chrfritsch 187d11f
Remove not used file
chrfritsch e49a670
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 02123b6
Use config_selector to get enabled media view
chrfritsch 5925e84
Try to fix config
chrfritsch f8b630a
Update search_api
chrfritsch 38326cf
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch e37591e
Merge branch 'develop' into feature/content-view-local-tasks
chrfritsch ae5fa45
Remove content_lock and scheduler fields
chrfritsch a4d5f91
Rename filters
chrfritsch 2316bc6
Enhance check for scheduler menu item
chrfritsch f0295b1
Add required modules and reimport content view
chrfritsch d9dac01
Check if route exists
chrfritsch a719ca0
Recover view only when content_lock was removed
chrfritsch 8b8f696
Wrong hook name
chrfritsch 815fdb5
CS fixes
chrfritsch 8ea6215
Add break
chrfritsch 23adcae
Add config form
chrfritsch 2c701c4
Add tests
chrfritsch d18e6b5
Cleanup
chrfritsch a3f70ef
Add group annotation
chrfritsch 96a1d6d
Import new content lock view
chrfritsch 3c75d72
Add update checklist point
chrfritsch 80f355e
Change wording
chrfritsch 84d52eb
Fix CS issue
chrfritsch cf8088e
Merge branch 'develop' into feature/content-view-local-tasks
chrfritsch 02a2ae8
Remove cache clears from Configuration form
alexpott 516dc4e
Fix caching
alexpott ef71d50
Less code and get to use a XOR
alexpott c781822
Less brakcets
alexpott 565b959
Do less in the loop and explain why \Drupal::service('config.factory'…
alexpott b523dca
Merge branch 'feature/content-view-local-tasks' into feature/2899254-…
chrfritsch a77e1c9
Remove EB search api view
chrfritsch 4d24654
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 5bbb4f4
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch efeaf52
Make search integration not enabled by default
chrfritsch c03410e
Fix config test
chrfritsch 21d934a
Merge branch 'develop' of https://github.com/BurdaMagazinOrg/thunder-…
chrfritsch 64c84ac
Add tests
chrfritsch ea686ac
[TEST_UPDATE=true] Trigger update test path
chrfritsch 5ddb005
[TEST_UPDATE=true] Trigger update test path
chrfritsch c2c4d5f
Add config_selector UI
chrfritsch 24877f9
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 778eebf
Add channel faces, update config_selector
chrfritsch cfdad76
Merge branch 'develop' into feature/2899254-integrate_editorial_searc…
chrfritsch 341678a
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 1147d01
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch e56a4f8
Fix CS
chrfritsch 245da54
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 84242e8
Adding descriptions
chrfritsch 3af291c
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
dbosen c3105fd
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 0543e40
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 4f25d1e
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 0107f18
Fix configs
chrfritsch a695a6c
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 1dece5a
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch ae259a6
Update search api
chrfritsch df2d353
Use select2 widget
chrfritsch 91d0d8e
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch badfa1d
Add tags facet
chrfritsch 3098241
Use select2 facet widget
chrfritsch 467cef3
Add views bulk patch
chrfritsch 8e64f41
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 0c46aa7
Update facets
chrfritsch bf9e4ed
Fix CS
chrfritsch cea413c
Add dev branch of select2
chrfritsch eef4ee2
Cleanup
chrfritsch fc0beca
Show message
chrfritsch 49c9122
WIP
chrfritsch 10d6fd8
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
dbosen 9b9daf7
Fix test
chrfritsch 6038bd3
Fix InstalledConfigurationTest
chrfritsch 08266a2
Add empty behavior text
chrfritsch 4424823
Hide status facet without narrowing results
chrfritsch a30aded
Fix comments
chrfritsch 8e95a3c
WIP
chrfritsch 134c8ba
Add patches
chrfritsch 00a17dc
Add patch to correct module
chrfritsch 8029ecc
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 9d9d072
Show numbers
chrfritsch d34f2bd
Change width
chrfritsch 4e5fe5b
Cache views
chrfritsch a30a5f2
Update views
chrfritsch eaf714f
Remove empty behavior
chrfritsch 98606a9
Add search_api_db as a soft dependency
chrfritsch 7f2c832
Add new search api patch
chrfritsch 64387ff
Update patch
chrfritsch d18e3e1
Activate query preserving
chrfritsch e5dafed
Add view classes
chrfritsch 1bb3710
Fix patch path
chrfritsch af70c51
Show titles with config
chrfritsch 7dd9b11
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
dbosen 9468567
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
dbosen 4cd7377
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 28964ea
Kill thunder_search
chrfritsch 6b10e70
Kill thunder_search leftovers
chrfritsch 1c17ccb
Update search_api
chrfritsch 119a25e
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 4e917d0
Cleanup config
chrfritsch 9df45a5
Update patches
chrfritsch e9cd588
Remove unneeded patch
chrfritsch bddd62b
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch b25f2e8
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 9d6eaa5
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
dbosen bddeb01
Add performance
chrfritsch 84061fe
Add search_api view displays
chrfritsch 18f272e
Fix tests
chrfritsch a2c30d1
Back to current core version
chrfritsch 49ebf04
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
dbosen fccc075
Add facet item limits
chrfritsch 91e4757
Add facets patxh
chrfritsch e374488
Remove media view
chrfritsch 24015b1
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 99d97d4
Remove core patch
chrfritsch b083776
Use block building in our facet block
chrfritsch 7d9f5eb
Simplify code
chrfritsch e3309fd
Render facet all the time
chrfritsch 0549f61
Use facet blocks
chrfritsch 49f7d44
Make select2 work
chrfritsch 32ee3ce
Update facets
chrfritsch 71250b6
Update patches
chrfritsch 1f53f2f
New patch
chrfritsch da242f4
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 3354f4d
Add fulltext block
chrfritsch 048aab8
Update patches
chrfritsch 570e44f
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 1a17609
Remove patch
chrfritsch 2e56812
Remove committed patch
chrfritsch 3f45b29
add search_api outdated items flagging
ol0lll c1e1b6d
Add data attr to search_api view output
ol0lll 62c966e
Merge branch 'feature/2899254-integrate_editorial_search_with_search_…
ol0lll d9bf3ba
use combined patch to fix views caching
ol0lll 26c83a1
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch c4d811a
move blocks to theme
ol0lll 0bdb1bc
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 995e61a
Move to update helper
chrfritsch 18474aa
Merge branch 'feature/2899254-integrate_editorial_search_with_search_…
ol0lll a06ab07
REVERT BEFORE COMMIT: switch to thunder_admin branch
ol0lll 28f4efd
Revert "REVERT BEFORE COMMIT: switch to thunder_admin branch"
ol0lll 0f0ef0d
REVERT BEFORE COMMIT: switch to thunder_admin branch using composer.json
ol0lll 28bd98c
Fix composer.json
dbosen 5b3c462
Fix branch
chrfritsch a097037
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 4cada2d
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch 6885e12
Merge branch '8.x-2.x' of github.com:BurdaMagazinOrg/thunder-distribu…
ol0lll 73aad0e
Merge branch '8.x-2.x' of github.com:BurdaMagazinOrg/thunder-distribu…
ol0lll 1d31aac
use facets release
ol0lll 01d3c0b
Merge branch '8.x-2.x' into feature/2899254-integrate_editorial_searc…
chrfritsch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,4 +4,4 @@ core: 8.x | |
| projects: | ||
| drupal: | ||
| type: core | ||
| version: 8.4.0 | ||
| version: 8.4.2 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
modules/thunder_search/config/optional/facets.facet.author.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| langcode: en | ||
| status: true | ||
| dependencies: | ||
| config: | ||
| - search_api.index.node | ||
| - views.view.content_search | ||
| module: | ||
| - search_api | ||
| id: author | ||
| name: Author | ||
| url_alias: author | ||
| weight: 0 | ||
| min_count: 1 | ||
| show_only_one_result: true | ||
| field_identifier: uid | ||
| facet_source_id: 'search_api:views_page__content_search__page_1' | ||
| widget: | ||
| type: dropdown | ||
| config: | ||
| show_numbers: false | ||
| default_option_label: Choose | ||
| query_operator: or | ||
| use_hierarchy: false | ||
| expand_hierarchy: false | ||
| enable_parent_when_child_gets_disabled: true | ||
| hard_limit: 10 | ||
| exclude: false | ||
| only_visible_when_facet_source_is_visible: true | ||
| processor_configs: | ||
| active_widget_order: | ||
| processor_id: active_widget_order | ||
| weights: | ||
| sort: -10 | ||
| settings: | ||
| sort: DESC | ||
| count_widget_order: | ||
| processor_id: count_widget_order | ||
| weights: | ||
| sort: -10 | ||
| settings: | ||
| sort: DESC | ||
| display_value_widget_order: | ||
| processor_id: display_value_widget_order | ||
| weights: | ||
| sort: -10 | ||
| settings: | ||
| sort: ASC | ||
| hide_1_result_facet: | ||
| processor_id: hide_1_result_facet | ||
| weights: | ||
| build: -10 | ||
| settings: { } | ||
| uid_to_username_callback: | ||
| processor_id: uid_to_username_callback | ||
| weights: | ||
| build: 5 | ||
| settings: { } | ||
| url_processor_handler: | ||
| processor_id: url_processor_handler | ||
| weights: | ||
| pre_query: -10 | ||
| build: -10 | ||
| settings: { } | ||
| empty_behavior: | ||
| behavior: none |
60 changes: 60 additions & 0 deletions
60
modules/thunder_search/config/optional/facets.facet.content_type.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| langcode: en | ||
| status: true | ||
| dependencies: | ||
| config: | ||
| - search_api.index.node | ||
| - views.view.content_search | ||
| module: | ||
| - search_api | ||
| id: content_type | ||
| name: 'Content type' | ||
| url_alias: content_type | ||
| weight: 0 | ||
| min_count: 1 | ||
| show_only_one_result: true | ||
| field_identifier: type | ||
| facet_source_id: 'search_api:views_page__content_search__page_1' | ||
| widget: | ||
| type: dropdown | ||
| config: | ||
| show_numbers: false | ||
| default_option_label: Choose | ||
| query_operator: or | ||
| use_hierarchy: false | ||
| expand_hierarchy: false | ||
| enable_parent_when_child_gets_disabled: true | ||
| hard_limit: 0 | ||
| exclude: false | ||
| only_visible_when_facet_source_is_visible: true | ||
| processor_configs: | ||
| active_widget_order: | ||
| processor_id: active_widget_order | ||
| weights: | ||
| sort: -10 | ||
| settings: | ||
| sort: DESC | ||
| count_widget_order: | ||
| processor_id: count_widget_order | ||
| weights: | ||
| sort: -10 | ||
| settings: | ||
| sort: DESC | ||
| display_value_widget_order: | ||
| processor_id: display_value_widget_order | ||
| weights: | ||
| sort: -10 | ||
| settings: | ||
| sort: ASC | ||
| translate_entity: | ||
| processor_id: translate_entity | ||
| weights: | ||
| build: 5 | ||
| settings: { } | ||
| url_processor_handler: | ||
| processor_id: url_processor_handler | ||
| weights: | ||
| pre_query: -10 | ||
| build: -10 | ||
| settings: { } | ||
| empty_behavior: | ||
| behavior: none | ||
67 changes: 67 additions & 0 deletions
67
modules/thunder_search/config/optional/facets.facet.promoted_to_front_page.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| langcode: en | ||
| status: true | ||
| dependencies: | ||
| config: | ||
| - search_api.index.node | ||
| - views.view.content_search | ||
| module: | ||
| - search_api | ||
| id: promoted_to_front_page | ||
| name: 'Promoted to front page' | ||
| url_alias: promoted_to_front_page | ||
| weight: 0 | ||
| min_count: 1 | ||
| show_only_one_result: true | ||
| field_identifier: promote | ||
| facet_source_id: 'search_api:views_page__content_search__page_1' | ||
| widget: | ||
| type: dropdown | ||
| config: | ||
| show_numbers: false | ||
| default_option_label: Choose | ||
| query_operator: or | ||
| use_hierarchy: false | ||
| expand_hierarchy: false | ||
| enable_parent_when_child_gets_disabled: true | ||
| hard_limit: 0 | ||
| exclude: false | ||
| only_visible_when_facet_source_is_visible: true | ||
| processor_configs: | ||
| active_widget_order: | ||
| processor_id: active_widget_order | ||
| weights: | ||
| sort: -10 | ||
| settings: | ||
| sort: DESC | ||
| boolean_item: | ||
| processor_id: boolean_item | ||
| weights: | ||
| build: -10 | ||
| settings: | ||
| on_value: 'Yes' | ||
| off_value: 'No' | ||
| count_widget_order: | ||
| processor_id: count_widget_order | ||
| weights: | ||
| sort: -10 | ||
| settings: | ||
| sort: DESC | ||
| display_value_widget_order: | ||
| processor_id: display_value_widget_order | ||
| weights: | ||
| sort: -10 | ||
| settings: | ||
| sort: ASC | ||
| hide_1_result_facet: | ||
| processor_id: hide_1_result_facet | ||
| weights: | ||
| build: -10 | ||
| settings: { } | ||
| url_processor_handler: | ||
| processor_id: url_processor_handler | ||
| weights: | ||
| pre_query: -10 | ||
| build: -10 | ||
| settings: { } | ||
| empty_behavior: | ||
| behavior: none |
72 changes: 72 additions & 0 deletions
72
modules/thunder_search/config/optional/facets.facet.status.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| langcode: en | ||
| status: true | ||
| dependencies: | ||
| config: | ||
| - search_api.index.node | ||
| - views.view.content_search | ||
| module: | ||
| - search_api | ||
| id: status | ||
| name: status | ||
| url_alias: status | ||
| weight: 0 | ||
| min_count: 1 | ||
| show_only_one_result: true | ||
| field_identifier: status | ||
| facet_source_id: 'search_api:views_page__content_search__page_1' | ||
| widget: | ||
| type: dropdown | ||
| config: | ||
| show_numbers: false | ||
| default_option_label: Choose | ||
| query_operator: or | ||
| use_hierarchy: false | ||
| expand_hierarchy: false | ||
| enable_parent_when_child_gets_disabled: true | ||
| hard_limit: 0 | ||
| exclude: false | ||
| only_visible_when_facet_source_is_visible: true | ||
| processor_configs: | ||
| active_widget_order: | ||
| processor_id: active_widget_order | ||
| weights: | ||
| sort: -10 | ||
| settings: | ||
| sort: DESC | ||
| boolean_item: | ||
| processor_id: boolean_item | ||
| weights: | ||
| build: -10 | ||
| settings: | ||
| on_value: Published | ||
| off_value: Unpublished | ||
| count_widget_order: | ||
| processor_id: count_widget_order | ||
| weights: | ||
| sort: -10 | ||
| settings: | ||
| sort: DESC | ||
| display_value_widget_order: | ||
| processor_id: display_value_widget_order | ||
| weights: | ||
| sort: -10 | ||
| settings: | ||
| sort: ASC | ||
| hide_1_result_facet: | ||
| processor_id: hide_1_result_facet | ||
| weights: | ||
| build: -10 | ||
| settings: { } | ||
| list_item: | ||
| processor_id: list_item | ||
| weights: | ||
| build: 5 | ||
| settings: { } | ||
| url_processor_handler: | ||
| processor_id: url_processor_handler | ||
| weights: | ||
| pre_query: -10 | ||
| build: -10 | ||
| settings: { } | ||
| empty_behavior: | ||
| behavior: none |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.