Merged
Conversation
…ged some 500s to 400s where appropriate to indicate user error (#85)
Member
Author
|
I didnt even intentionally do this, but this PR will resolve #103 |
This was
linked to
issues
Apr 8, 2026
costowell
reviewed
Apr 8, 2026
Contributor
costowell
left a comment
costowell
left a comment
There was a problem hiding this comment.
Tiny nitpicks, overall looks good
templates/create.tmpl
Outdated
|
|
||
| {{ if .EBoard }} | ||
| <div id="eboard-options" class="my-4"> | ||
| <h5 class="text-decoration-underline">E-Board Options</h5> |
Contributor
There was a problem hiding this comment.
IMO, the underline doesn't look right
templates/create.tmpl
Outdated
| </div> | ||
| <div class="form-group"> | ||
|
|
||
| <h5 class="mt-4 text-decoration-underline">Additional Settings</h5> |
Contributor
There was a problem hiding this comment.
IMO, the underline doesn't look right
|
pikachu0542
added a commit
that referenced
this pull request
Apr 9, 2026
* Changed all status codes to the http.StatusCode equivalent. Also changed some 500s to 400s where appropriate to indicate user error (#85) * Started working on navbar * More progress * working theme selector * Eboard vote link appears on all pages * Started working on navbar * More progress * working theme selector * Rebase with dev * Finished rebasing with dev * Added favicon import * Misc other stuff, navbar is responsive now * larger nav title * Quorum text input, create page basically done * Finished poll creation page * Ranked choice poll page is done * Actually use the hidden template * changed icon * Fixed vote count on eboard votes * Added display of total votes submitted to results * small fixes * fixed spacing between buttons for eboard vote on mobile * poll title wrapping in a different place * Changed underline to bold * Capitalize description placeholder text --------- Co-authored-by: Noah Hanford <bigspaceships56@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Upgrades the bootstrap version to 5.3, and then reworked all the styles to use only bootstrap 5
Why
Bootstrap 5 is good and the styles look way better now
Test Plan
Run locally. ensure all functionality works as expected. Ensure all page components look normal on desktop and mobile
Env Vars
Nope
Documentation
None needed
Checklist