Skip to content

TypeAnalysis: fall back to LLVM type for extractvalue when operand has no type info #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+42 −5
Draft

TypeAnalysis: fall back to LLVM type for extractvalue when operand has no type info #2783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb5eced
Initial plan
Copilot Apr 9, 2026
a8fb578
Fix TypeAnalysis: propagate float type info through extractvalue from…
Copilot Apr 9, 2026
c9ef9cb
Add CHECK lines for intermediate extractvalue results in test
Copilot Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions enzyme/Enzyme/TypeAnalysis/TypeAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2839,11 +2839,17 @@ void TypeAnalyzer::visitExtractValueInst(ExtractValueInst &I) {
int off = (int)ai.getLimitedValue();
int size = dl.getTypeSizeInBits(I.getType()) / 8;

if (direction & DOWN)
updateAnalysis(&I,
getAnalysis(I.getOperand(0))
.ShiftIndices(dl, off, size, /*addOffset*/ 0),
&I);
if (direction & DOWN) {
auto res = getAnalysis(I.getOperand(0))
.ShiftIndices(dl, off, size, /*addOffset*/ 0);
// If no type info was propagated from the operand (e.g., the operand is
// an opaque call result with no known type info), fall back to using the
// LLVM type of the result to generate type info. For extractvalue, the
// LLVM type of the extracted field is authoritative.
if (!res.isKnown())
res = defaultTypeTreeForLLVM(I.getType(), &I, /*intIsPointer*/ false);
updateAnalysis(&I, res, &I);
}

if (direction & UP)
updateAnalysis(I.getOperand(0),
Expand Down
31 changes: 31 additions & 0 deletions enzyme/test/TypeAnalysis/extractvalue_opaque_call.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
; RUN: if [ %llvmver -lt 16 ]; then %opt < %s %loadEnzyme -print-type-analysis -type-analysis-func=caller -o /dev/null | FileCheck %s; fi
; RUN: %opt < %s %newLoadEnzyme -passes="print-type-analysis" -type-analysis-func=caller -S -o /dev/null | FileCheck %s

; Test that extractvalue from a call returning a struct with float arrays
; properly propagates type information even when the aggregate operand has
; no known type (e.g., from an opaque function call result).

target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"

%struct.c_v = type { [2 x float], [2 x [3 x float]] }

declare %struct.c_v @pre_work()

define void @caller() {
entry:
%cv = call %struct.c_v @pre_work()
%f2 = extractvalue %struct.c_v %cv, 0
%f2x3 = extractvalue %struct.c_v %cv, 1
%f0 = extractvalue [2 x float] %f2, 0
%f1 = extractvalue [2 x float] %f2, 1
%f00 = extractvalue [2 x [3 x float]] %f2x3, 0, 0
ret void
}

; CHECK-LABEL: caller
; CHECK: %f2 = extractvalue %struct.c_v %cv, 0: {[-1]:Float@float}
; CHECK: %f2x3 = extractvalue %struct.c_v %cv, 1: {[-1]:Float@float}
; CHECK: %f0 = extractvalue [2 x float] %f2, 0: {[-1]:Float@float}
; CHECK: %f1 = extractvalue [2 x float] %f2, 1: {[-1]:Float@float}
; CHECK: %f00 = extractvalue [2 x [3 x float]] %f2x3, 0, 0: {[-1]:Float@float}