feat(CLI)!: adopt ESM for blocks and themes#1482
Merged
Conversation
SamuelAlev
requested review from
michael-georgiadis and
oliverschwendener
and removed request for
a team
🦋 Changeset detectedLatest commit: 4fced25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ragi96
reviewed
Mar 26, 2026
| rolldownOptions: { | ||
| platform: 'browser', | ||
| treeshake: { | ||
| // TODO: Fix in Fondue |
Collaborator
There was a problem hiding this comment.
Suggested change
| // TODO: Fix in Fondue |
I assume this one is fixed?
Member
Author
There was a problem hiding this comment.
Nope, I'll have to ask Noah to look into it
ragi96
approved these changes
Mar 31, 2026
Collaborator
ragi96
left a comment
ragi96
left a comment
There was a problem hiding this comment.
Tested with react18 and react19 works perfectly fine.
Let's do an alpha release :)
ragi96
requested review from
julianiff and
mike85
and removed request for
michael-georgiadis and
oliverschwendener
|
julianiff
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(based on
devbranch, will do few alpha release before increasing the major)