Skip to content

Fix wire bugs #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KostyaCholak wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Fix wire bugs #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
85a6520
Make wires bidirectional
Sep 6, 2020
17f4deb
Improve perfomance by updating only wires that changed value
Sep 6, 2020
9e9b673
Update wires in one step
Sep 6, 2020
40af122
Fix wire flickering when two opposite inputs
Sep 6, 2020
465f6b5
Fix remove wire outputs check
Sep 6, 2020
ff55c99
Fix self and loop powering
Sep 6, 2020
65966f1
Add null checks
Sep 6, 2020
3356db9
Fix flickering wires appering to have constant value
Sep 7, 2020
c88b329
Give update priority to wire's "to" than to "output"
Sep 8, 2020
9ed3d12
Allow multiple connections to one port
Sep 9, 2020
3423748
Update input ports
Sep 9, 2020
e20820e
Connect wire to port, not to port's wire
Sep 9, 2020
f361f65
Remove console.log
Sep 9, 2020
7bb9974
Show tips in the corner
Sep 9, 2020
50697ee
Check if input and output exists
Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
256 changes: 162 additions & 94 deletions app/js/canvas.js
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion app/js/componentUpdates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,23 @@ let ticksPerSecond = 0;

let pauseSimulation = false;
let updates;
let maxUpdatesInitial = 10000;
let maxUpdates = maxUpdatesInitial;


function tick() {
const start = new Date;
updates = 0;

while(updateQueue.length > 0 && updates < 10000 && !pauseSimulation) {
while(updateQueue.length > 0 && updates < maxUpdates && !pauseSimulation) {
updateQueue.splice(0,1)[0]();
++updates;
}

// randomize max updates, so that flickering wires will flicker on screen as their value will be different each tick
// due to different max updates
maxUpdates = maxUpdatesInitial + Math.floor(Math.random() * Math.floor(100)) - 50;

ticksPerSecond = 1000 / (new Date - lastTick);
lastTick = new Date;
}
Expand Down
Loading