Skip to content

Fix: Accessible name mismatch for AI Chat button #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huangkevin-apr wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: Accessible name mismatch for AI Chat button #3934

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5be6586
Fix: Accessible name mismatch for AI Chat button
huangkevin-apr Jan 23, 2026
c9f2c10
Merge branch 'main' into fix-a11y-ai-icon
SamyPesse Jan 28, 2026
bc80ccb
Fix AI chat button aria-label and add changeset
huangkevin-apr Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/gitbook/src/components/AIChat/AIChatButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export function AIChatButton(props: {
iconOnly={!showLabel || isMobile}
size="medium"
variant="header"
aria-label={t(language, 'ai_chat_ask', assistant.label)}
Copy link
Copy Markdown
Member

@SamyPesse SamyPesse Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to use tString here, otherwise it returns a ReactNode

Copy link
Copy Markdown
Author

@huangkevin-apr huangkevin-apr Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback, I have updated these details.

label={
<div className="flex items-center gap-2">
{t(language, 'ai_chat_ask', assistant.label)}
Expand Down
Loading