-
Notifications
You must be signed in to change notification settings - Fork 4k
Rework page layout #4013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zenoachtig
wants to merge
27
commits into
main
Choose a base branch
from
page-layout-rework
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rework page layout #4013
Changes from 4 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
0cf494f
Rework page layout
zenoachtig 5779b72
Update TableOfContents.tsx
zenoachtig 5ccd2dc
Comments & rename
zenoachtig 87443db
Update PageCover.tsx
zenoachtig 4c552c5
Merge branch 'main' into page-layout-rework
zenoachtig 1282c3f
Add pageaside sidesheet
zenoachtig 42f2076
Update EmbeddableDocsPage.tsx
zenoachtig 081f9e6
Merge branch 'main' into page-layout-rework
zenoachtig f5902a6
Improved version
zenoachtig 3397549
Refactor
zenoachtig 4ca020c
Format
zenoachtig 0a26acf
Merge branch 'main' into page-layout-rework
zenoachtig 2be16ce
First naive pass
zenoachtig 656510f
Update PageCover.tsx
zenoachtig c93d777
Finish refactor
zenoachtig 9ebad52
Merge branch 'main' into page-layout-rework
zenoachtig ae0b730
Try-out showing the outline earlier for pages with API block
zenoachtig 984a822
Cleanup / refactor
zenoachtig e813918
Tweaks to cover and page actions
zenoachtig 2e921c2
Update PageAside.tsx
zenoachtig 1823d42
"On this page" header & mobile TOC margin
zenoachtig db846c9
Fix animations that were causing header issues
zenoachtig 83bfe42
Update tests
zenoachtig 1ec9bc6
Update internal.spec.ts
zenoachtig 87ded02
Update PageHeader.tsx
zenoachtig 6709ca7
Update PageHeader.tsx
zenoachtig e45c6e9
Merge branch 'main' into page-layout-rework
zenoachtig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "gitbook": minor | ||
| --- | ||
|
|
||
| Rework page layout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.