Skip to content

Fix Very long text does not forcibly wrap at its max width#4019

Open
Annonnymmousss wants to merge 1 commit intoGraphiteEditor:masterfrom
Annonnymmousss:fix/text_box_constraint_breakage
Open

Fix Very long text does not forcibly wrap at its max width#4019
Annonnymmousss wants to merge 1 commit intoGraphiteEditor:masterfrom
Annonnymmousss:fix/text_box_constraint_breakage

Conversation

@Annonnymmousss
Copy link
Copy Markdown
Contributor

closes #4009

Screen.Recording.2026-04-09.at.4.05.43.AM.mov

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Confidence score: 5/5

  • This looks low risk to merge because the only flagged item is PR metadata (title style), not a behavioral change in the code.
  • The reported issue is a process/compliance concern (remove fix: and use sentence case), so user-facing runtime regression risk appears minimal.
  • Pay close attention to node-graph/nodes/text/src/text_context.rs - verify no functional text-wrapping behavior changed beyond what the title-format check implies.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/nodes/text/src/text_context.rs">

<violation number="1" location="node-graph/nodes/text/src/text_context.rs:80">
P1: Custom agent: **PR title enforcement**

PR title uses a conventional commit prefix and starts with a lowercase word. Rename it to sentence case without the `fix:` prefix (e.g., "Fix very long text not forcibly wrapping at its max width").</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@Annonnymmousss Annonnymmousss changed the title fix: Very long text does not forcibly wrap at its max width Very long text does not forcibly wrap at its max width Apr 8, 2026
@Annonnymmousss Annonnymmousss changed the title Very long text does not forcibly wrap at its max width Fix Very long text does not forcibly wrap at its max width Apr 8, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the text layout logic in text_context.rs by importing OverflowWrap and setting OverflowWrap::BreakWord as a default style property. This change ensures that text will wrap by breaking words when necessary. I have no feedback to provide.

@Keavon
Copy link
Copy Markdown
Member

Keavon commented Apr 8, 2026

!build (Run ID 24163097135)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

📦 Web Build Complete for 35b9098
https://1c4acce6.graphite.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Very long text does not forcibly wrap at its max width

2 participants