Conversation
biiit4894
requested review from
dev-jungbin,
devkwonsehoon,
dragontaek-lee and
hyeyoon100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SERVER PR
🐕 과제 구현 명세
🐥 이런 점이 새로웠어요 / 어려웠어요
저는 사실 controller, router, service의 폴더구조도 상당히 낯설어서 각각이 무슨 역할인지 다시 찾아보고 또 찾아보고 계속 그랬는데 역시 실전을 맞닥뜨려야 이해가 되는게 맞는 것 같네요.. 그래도 합세와 솝커톤을 거치니 이제야 각각의 역할이 어떤 것인지 좀 감이 잡히는 것 같습니다! 적어도 코드를 보고 아 이건 뭔가 컨트롤러 같다 서비스 같다 정도의 구분은 가능해졌습니다 ^^
다만 유저 생성시 어떤 조건을 지켜야 하는지 (?) 는 뭔가 service나 controller상에 작성해야할 것만 같은데 router에서 인자로 작성해주는 것을 보고.. 약간 멘붕이 올뻔했던 것 같습니다 ㅋ 어쩌겠어요 저는 할 수 있습니다ㅏ~ 공부하는수밖에~~
src/router/userRouter.ts