Adding Libdl as dependency (this allows custom gmsh installations)#34
Open
fverdugo wants to merge 2 commits intoJuliaFEM:masterfrom
Open
Adding Libdl as dependency (this allows custom gmsh installations)#34fverdugo wants to merge 2 commits intoJuliaFEM:masterfrom
fverdugo wants to merge 2 commits intoJuliaFEM:masterfrom
Conversation
Author
|
It also would be nice to add a new test that actually tests using a custom installation of Gmsh, so that tests break if one removes the dependency to Libdl. However, I don't have much time to do it right now... If someone volunteers, here it is an example that can serve as starting point: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to the (tentative) PR #31
cc @fredrikekre @KristofferC