Skip to content

re-enable FP16 tests on PoCL#424

Merged
christiangnrd merged 4 commits intoJuliaGPU:masterfrom
franz:enable_fp16_on_PoCL
Apr 11, 2026
Merged

re-enable FP16 tests on PoCL#424
christiangnrd merged 4 commits intoJuliaGPU:masterfrom
franz:enable_fp16_on_PoCL

Conversation

@franz
Copy link
Copy Markdown
Contributor

@franz franz commented Mar 5, 2026

These tests should work on the CI after pocl/pocl#2128 lands in PoCL's main branch. Currently the PR is failing with errors like:

Error During Test at /home/runner/work/pocl/pocl/OpenCL.jl/test/intrinsics.jl:116
 Unexpected Pass
 Expression: call_on_device(f, x, y) ≈ f(x, y)
 Got correct result, please change to @test if no longer broken.

(the FP16 support in PoCL is still not 100% complete, but with the PR it'll be quite close)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2026

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/test/intrinsics.jl b/test/intrinsics.jl
index 57b0d44..4e3d181 100644
--- a/test/intrinsics.jl
+++ b/test/intrinsics.jl
@@ -96,7 +96,7 @@ end
         if f == acosh
             x += 1
         end
-        @test call_on_device(f, x) ≈ f(x)
+                @test call_on_device(f, x) ≈ f(x)
     end
 end
 
@@ -111,7 +111,7 @@ end
         ]
         x = rand(T)
         y = rand(T)
-        @test call_on_device(f, x, y) ≈ f(x, y)
+                @test call_on_device(f, x, y) ≈ f(x, y)
     end
 end
 
@@ -136,7 +136,7 @@ end
             OpenCL.rsqrt,
         ]
         x = rand(T)
-        broken = ispocl && T == Float16 && (f == OpenCL.logb)
+                broken = ispocl && T == Float16 && (f == OpenCL.logb)
         @test call_on_device(f, x) isa Real broken = broken  # Just check it doesn't error
     end
     broken = ispocl && T == Float16
@@ -155,7 +155,7 @@ end
         ]
         x = rand(T)
         y = rand(T)
-        broken = ispocl && T == Float16 && (f in [OpenCL.nextafter, OpenCL.powr])
+                broken = ispocl && T == Float16 && (f in [OpenCL.nextafter, OpenCL.powr])
         @test call_on_device(f, x, y) isa Real broken = broken  # Just check it doesn't error
     end
     broken = ispocl && T == Float16

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.26%. Comparing base (edfa2c4) to head (4e37857).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   80.13%   80.26%   +0.13%     
==========================================
  Files          12       12              
  Lines         745      745              
==========================================
+ Hits          597      598       +1     
+ Misses        148      147       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vchuravy
Copy link
Copy Markdown
Member

vchuravy commented Mar 5, 2026

Is there a way we can feature test for the PR? Then we can merge it here quickly, but also don't have failing CI here.

@franz
Copy link
Copy Markdown
Contributor Author

franz commented Mar 5, 2026

I could switch the repo in .github/workflows/Test.yml to my branch, then drop the commit.

@franz franz force-pushed the enable_fp16_on_PoCL branch 3 times, most recently from b85ca31 to 5416363 Compare March 9, 2026 17:43
@franz
Copy link
Copy Markdown
Contributor Author

franz commented Mar 12, 2026

@simeonschaub Hi can you rerun the failing CI jobs, at least the ARM should pass now.

franz and others added 4 commits April 11, 2026 17:01
These tests should work on the CI after
pocl/pocl#2128
lands in PoCL. Currently it's failing
with errors like:

Error During Test at /home/runner/work/pocl/pocl/OpenCL.jl/test/intrinsics.jl:116
 Unexpected Pass
 Expression: call_on_device(f, x, y) ≈ f(x, y)
 Got correct result, please change to @test if no longer broken.
this is not strictly necessary, but it should help by
enabling vectorized builtin variants on ARM64.
@christiangnrd
Copy link
Copy Markdown
Member

christiangnrd commented Apr 11, 2026

I'll be merging this once the final test either passes or times out Intrinsics tests passed, hang probably unrelated

@christiangnrd christiangnrd merged commit 58306b3 into JuliaGPU:master Apr 11, 2026
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants