re-enable FP16 tests on PoCL#424
Conversation
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/test/intrinsics.jl b/test/intrinsics.jl
index 57b0d44..4e3d181 100644
--- a/test/intrinsics.jl
+++ b/test/intrinsics.jl
@@ -96,7 +96,7 @@ end
if f == acosh
x += 1
end
- @test call_on_device(f, x) ≈ f(x)
+ @test call_on_device(f, x) ≈ f(x)
end
end
@@ -111,7 +111,7 @@ end
]
x = rand(T)
y = rand(T)
- @test call_on_device(f, x, y) ≈ f(x, y)
+ @test call_on_device(f, x, y) ≈ f(x, y)
end
end
@@ -136,7 +136,7 @@ end
OpenCL.rsqrt,
]
x = rand(T)
- broken = ispocl && T == Float16 && (f == OpenCL.logb)
+ broken = ispocl && T == Float16 && (f == OpenCL.logb)
@test call_on_device(f, x) isa Real broken = broken # Just check it doesn't error
end
broken = ispocl && T == Float16
@@ -155,7 +155,7 @@ end
]
x = rand(T)
y = rand(T)
- broken = ispocl && T == Float16 && (f in [OpenCL.nextafter, OpenCL.powr])
+ broken = ispocl && T == Float16 && (f in [OpenCL.nextafter, OpenCL.powr])
@test call_on_device(f, x, y) isa Real broken = broken # Just check it doesn't error
end
broken = ispocl && T == Float16 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #424 +/- ##
==========================================
+ Coverage 80.13% 80.26% +0.13%
==========================================
Files 12 12
Lines 745 745
==========================================
+ Hits 597 598 +1
+ Misses 148 147 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is there a way we can feature test for the PR? Then we can merge it here quickly, but also don't have failing CI here. |
|
I could switch the repo in |
b85ca31 to
5416363
Compare
|
@simeonschaub Hi can you rerun the failing CI jobs, at least the ARM should pass now. |
5416363 to
1c3685c
Compare
These tests should work on the CI after pocl/pocl#2128 lands in PoCL. Currently it's failing with errors like: Error During Test at /home/runner/work/pocl/pocl/OpenCL.jl/test/intrinsics.jl:116 Unexpected Pass Expression: call_on_device(f, x, y) ≈ f(x, y) Got correct result, please change to @test if no longer broken.
This reverts commit 1c3685c.
this is not strictly necessary, but it should help by enabling vectorized builtin variants on ARM64.
ea7b866 to
4e37857
Compare
|
|
These tests should work on the CI after pocl/pocl#2128 lands in PoCL's main branch. Currently the PR is failing with errors like:
(the FP16 support in PoCL is still not 100% complete, but with the PR it'll be quite close)