chore(ci): ruff py310 target, ruff-action, uvx pre-commit & fix uv build#483
Open
bhimrazy wants to merge 6 commits intoLightning-AI:mainfrom
Open
chore(ci): ruff py310 target, ruff-action, uvx pre-commit & fix uv build#483bhimrazy wants to merge 6 commits intoLightning-AI:mainfrom
bhimrazy wants to merge 6 commits intoLightning-AI:mainfrom
Conversation
…mmit - Set ruff target-version to py310 in pyproject.toml - Add check-ruff.yml reusable workflow using astral-sh/ruff-action@v3 with --output-format=github for inline PR annotations - Simplify pre-commit run step to use uvx pre-commit
bhimrazy
requested review from
ethanwharris,
justusschock,
lantiga and
tchaton
as code owners
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
=====================================
Coverage ? 72%
=====================================
Files ? 17
Lines ? 749
Branches ? 0
=====================================
Hits ? 540
Misses ? 209
Partials ? 0 🚀 New features to boost your workflow:
|
uv venvs don't include pip by default; build v1.4 bootstraps its isolated env via `pip --python` which fails with "No module named pip". Using uv build bypasses pip entirely and is consistent with the uv-based stack.
bhimrazy
changed the title
Borda
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
rufftarget-versiontopy310inpyproject.tomland applies the resulting pyupgrade auto-fixes (Optional[X]→X | None,Union[X, Y]→X | Y,Callablefromcollections.abc)check-ruff.ymlworkflow usingastral-sh/ruff-action@v3with--output-format=githubfor inline PR annotationsuv pip install pre-commit && pre-commit→uvx pre-commitpkg-createaction: replacespython -m buildwithuv buildto avoidNo module named piperror in uv venvs (uv venvs don't include pip;build1.4 bootstraps its isolated env viapip --pythonwhich fails)PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.