Skip to content

fix(policy): update HuggingFace endpoint and restrict Discord DELETE method #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 4 commits into from
Apr 9, 2026
+5 −2
Merged

fix(policy): update HuggingFace endpoint and restrict Discord DELETE method #1540

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b4d87b
fix(policy): update HuggingFace endpoint and restrict Discord DELETE …
BenediktSchackenberg Apr 6, 2026
2297a37
fix(policy): fix Discord reaction DELETE path — requires two trailing…
BenediktSchackenberg Apr 6, 2026
a8609dd
Merge branch 'main' into fix/policy-preset-fixes
BenediktSchackenberg Apr 8, 2026
eb3efff
Merge branch 'main' into fix/policy-preset-fixes
cv Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion nemoclaw-blueprint/policies/presets/discord.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ network_policies:
- allow: { method: POST, path: "/**" }
- allow: { method: PUT, path: "/**" }
- allow: { method: PATCH, path: "/**" }
- allow: { method: DELETE, path: "/**" }
# DELETE only on message and reaction endpoints — not all paths
- allow: { method: DELETE, path: "/api/v*/channels/*/messages/*" }
- allow: { method: DELETE, path: "/api/v*/channels/*/messages/*/reactions/*" }
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reaction DELETE path pattern looks too narrow for Discord's reaction removal endpoints, which include an additional path segment (e.g., /reactions/{emoji}/@me or /reactions/{emoji}/{user_id}). With the current /reactions/* pattern, DELETE requests to remove a reaction will likely be blocked. Consider expanding the allowed path to include that trailing segment(s) while still keeping it scoped under the message reaction subtree.

Suggested change
- allow: { method: DELETE, path: "/api/v*/channels/*/messages/*/reactions/*" }
- allow: { method: DELETE, path: "/api/v*/channels/*/messages/*/reactions/*/*" }

Copilot uses AI. Check for mistakes.
# WebSocket gateway — must use access: full (CONNECT tunnel) instead
# of protocol: rest. The proxy's HTTP idle timeout (~2 min) kills
# long-lived WebSocket connections; a CONNECT tunnel avoids
Expand Down
2 changes: 1 addition & 1 deletion nemoclaw-blueprint/policies/presets/huggingface.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ network_policies:
tls: terminate
rules:
- allow: { method: GET, path: "/**" }
- host: api-inference.huggingface.co
- host: router.huggingface.co
port: 443
protocol: rest
enforcement: enforce
Expand Down
Loading