fix(test): recreate tmpDir per test in onboard-session.test.ts (#1284)

[ColinM-sys]

Summary

Closes #1284.

The lock-related tests in src/lib/onboard-session.test.ts share a single tmpDir created once at module load. releaseOnboardLock() (and any future test that crashes mid-flight) can leave lock artifacts behind that the existing beforeEach does not clean up — it only clears the module cache and session file. That makes lock cases order-dependent.

Fix

Recreate tmpDir in beforeEach and fs.rmSync it in afterEach, so every test starts from a guaranteed-clean directory.

No production code changes; this is purely test isolation.

Test plan

• vitest run src/lib/onboard-session.test.ts — 13 lock/session tests still pass.
• One pre-existing failure (mode & 0o777 === 0o600) is a Windows-only POSIX-permissions limitation that exists on main with or without this change. Confirmed by stashing the patch and re-running on the same checkout.

Summary by CodeRabbit

• Tests
  • Improved test isolation and cleanup procedures to ensure each test runs with a fresh environment and all temporary artifacts are properly removed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 669bd0ff-c2c0-482b-a015-f1c8abc895ec

📥 Commits

Reviewing files that changed from the base of the PR and between bbec268 and beba464.

📒 Files selected for processing (1)

• src/lib/onboard-session.test.ts

---

📝 Walkthrough

Walkthrough

The test file now creates and destroys a fresh temporary directory for each test case in beforeEach and afterEach hooks respectively, replacing the module-level tmpDir pattern. Module cache clearing occurs after directory creation, and cleanup now includes recursive removal of the temporary directory to eliminate leftover lock artifacts between tests.

Changes

Cohort / File(s)	Summary
Test Isolation Fix src/lib/onboard-session.test.ts	Moved tmpDir creation from module-level into beforeEach and added recursive directory cleanup in afterEach. Cache clearing now occurs after directory setup. Resolves test order dependency caused by shared lock files persisting across test runs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

A rabbit hops through test files with care,
Creating fresh tunnels, wiping lock hairs,
Each test starts clean, no stragglers left behind,
Order dependence? Not this time we'll find! 🐰✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing a test isolation issue by recreating tmpDir per test in a specific test file, with issue reference.
Linked Issues check	✅ Passed	The PR directly addresses issue #1284 by recreating tmpDir in beforeEach and removing it in afterEach to eliminate test order dependence caused by shared lock artifacts.
Out of Scope Changes check	✅ Passed	All changes are scoped to test isolation improvements in src/lib/onboard-session.test.ts with no production code modifications, fully aligned with issue #1284 objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[wscurran]

✨ Thanks for submitting this fix, which proposes a way to improve test reliability by ensuring a clean temporary directory for each test case.