Skip to content

Strip local version labels from package version checks #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pstjohn wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Strip local version labels from package version checks #2858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97518a9
Strip local version labels from package version checks
pstjohn Apr 8, 2026
109f8c7
Merge branch 'main' into pstjohn/strip-public-versions
ksivaman Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion transformer_engine/jax/version_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
@lru_cache(maxsize=None)
def jax_version_meet_requirement(version: str):
"""Return True if the installed JAX version is >= the required version."""
jax_version = PkgVersion(get_pkg_version("jax"))
jax_version = PkgVersion(PkgVersion(get_pkg_version("jax")).public)
jax_version_required = PkgVersion(version)
return jax_version >= jax_version_required

Expand Down
4 changes: 2 additions & 2 deletions transformer_engine/pytorch/attention/dot_product_attention/backends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
_flash_attn_varlen_fwd = None
_flash_attn_varlen_bwd = None
try:
fa_utils.version = PkgVersion(get_pkg_version("flash-attn"))
fa_utils.version = PkgVersion(PkgVersion(get_pkg_version("flash-attn")).public)
except PackageNotFoundError:
pass # only print warning if use_flash_attention_2 = True in get_attention_backend
else:
Expand Down Expand Up @@ -132,7 +132,7 @@
fa_utils.version,
)
try:
fa_utils.fa3_version = PkgVersion(get_pkg_version("flash-attn-3"))
fa_utils.fa3_version = PkgVersion(PkgVersion(get_pkg_version("flash-attn-3")).public)
except PackageNotFoundError:
flash_attn_func_v3 = None
flash_attn_varlen_func_v3 = None
Expand Down
Loading