Fix invalid relative links in welcome workflow comments#488
Merged
yuanchen8911 merged 1 commit intoNVIDIA:mainfrom Apr 9, 2026
Merged
Fix invalid relative links in welcome workflow comments#488yuanchen8911 merged 1 commit intoNVIDIA:mainfrom
yuanchen8911 merged 1 commit intoNVIDIA:mainfrom
Conversation
kannon92
commented
Apr 3, 2026
1 task
auto-merge was automatically disabled
April 3, 2026 19:50
Head branch was pushed to by a user without write access
88fd4ba to
2d6b378
Compare
Contributor
Author
|
@mchmarny I had to repush to sign my commits. So this probably needs a new approver but nothng else changed. |
mchmarny
approved these changes
Apr 8, 2026
auto-merge was automatically disabled
April 9, 2026 18:39
Head branch was pushed to by a user without write access
3101a90 to
63fd93a
Compare
Signed-off-by: Kevin Hannon <kehannon@redhat.com>
63fd93a to
bc49b99
Compare
Contributor
|
/lgtm |
yuanchen8911
approved these changes
Apr 9, 2026
Contributor
yuanchen8911
left a comment
There was a problem hiding this comment.
Clean fix — all 4 broken relative links replaced with absolute GitHub URLs using template literals. Cross-reviewed by Claude Code, Codex, and CodeRabbit with no findings.
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix broken relative links in the GitHub Actions welcome workflow that produced invalid URLs in issue and PR welcome comments.
Motivation / Context
The welcome workflow used relative markdown links (e.g.,
../blob/main/CONTRIBUTING.md,../../labels) which don't resolve correctly when rendered in GitHub issue/PR comments. This caused new contributors to encounter broken links on their first interaction with the project.Fixes: N/A
Related: N/A
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/).github/workflows/welcome.yaml)Implementation Notes
Replaced relative markdown links with fully-qualified GitHub URLs using
context.repo.ownerandcontext.repo.repotemplate variables. This ensures links resolve correctly regardless of where the comment is rendered. Changed the affected lines from single-quoted strings to template literals to enable variable interpolation.Testing
Risk Assessment
Rollout notes: N/A
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info