add kueue components as an option#490
Conversation
ArangoGutierrez
left a comment
There was a problem hiding this comment.
Hey Kevin, thanks for adding this. A couple things to fix before this is ready.
|
I'm having a hard time figuring out how to test this on a kind cluster. I was thinking that I could have a bundle and verify simple kind cluster for Kueue but can't figure out how to do that. |
9a20673 to
3f702e0
Compare
In response to this comment, I have created #508 , with it, is easier for contributors to fully test the component in a controlled environment, even if the contributor doesn't have access to a GPU by using the NVML-Mock project. Hope this helps @kannon92 |
Cross-Review Summary for PR #490Reviewers: Codex, CodeRabbit + Integration Analysis Confirmed IssuesNone. The PR is correct as written. Positive Observations
Cross-review by Claude Code + Codex + CodeRabbit |
|
@kannon92 , can you rebase on main. |
197b1fb to
7d7a177
Compare
yuanchen8911
left a comment
There was a problem hiding this comment.
Cross-Review Summary (Claude Code + Codex + CodeRabbit + Integration Analysis)
Rounds: 1 | Consensus: Yes | Confirmed issues: 0
Result: No findings.
All four reviewers independently confirmed this PR follows established patterns exactly. The registry entry, values.yaml, and health check are consistent with existing components (kubeflow-trainer, kai-scheduler, etc.).
Residual Risk
| Risk | Notes |
|---|---|
| No overlay references kueue yet | Component is inert until an overlay/mixin adds a componentRef — expected for new components |
| Chart version not verified | oci://registry.k8s.io/kueue/charts/kueue:0.17.0 is an external artifact |
Broad toleration (operator: Exists) |
Kueue controller schedules on any node; system nodeScheduling tolerations are redundant but harmless |
Positive Observations
- All three files follow established patterns (registry, values, chainsaw health check)
- nodeScheduling paths internally consistent with values.yaml structure
- Version string properly quoted to avoid YAML float interpretation
6b32aec to
1f32c34
Compare
Signed-off-by: Kevin Hannon <kehannon@redhat.com>
1f32c34 to
f420487
Compare
Summary
Add kueue recipe.
Motivation / Context
Fixes: #486
Related:
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
Testing
# Commands run (prefer `make qualify` for non-trivial changes) make qualifyRisk Assessment
Rollout notes:
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info