[backport 3.2] Backport #7241 and #8027#8293
Open
davebayer wants to merge 2 commits intoNVIDIA:branch/3.2.xfrom
Open
[backport 3.2] Backport #7241 and #8027#8293davebayer wants to merge 2 commits intoNVIDIA:branch/3.2.xfrom
davebayer wants to merge 2 commits intoNVIDIA:branch/3.2.xfrom
Conversation
) * Add a test for <nv/target> to validate old dialect support. * Check CMAKE_<LANG>_FEATURES for compatible standards * spelling fixup * Check host compiler compatibility for CUDA as well * Rename target for nvtarget test * [pre-commit.ci] auto code formatting --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit aea68d7)
) (cherry picked from commit e1a7506)
This comment has been minimized.
This comment has been minimized.
Collaborator
|
When do do backports, can we make sure the PR description includes motivation for why the backport is needed? |
Contributor
Author
Sure, I've updated the description |
Contributor
😬 CI Workflow Results🟥 Finished in 1d 12h: Pass: 99%/264 | Total: 11d 13h | Max: 5h 30m | Hits: 42%/383112See results here. |
miscco
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to backport
NV_HAS_FEATURE_SM_XYffixes to 3.3 and 3.2, because something likeNV_IF_TARGET(NV_HAS_FEATURE_SM_XYf, ...)doesn't do the right thing, whenXYis not exactly the architecture we are currently compiling for. It is a bug that can have very surprising effects for the users.This PR also backports #7241 on which #8027 depends on.