Extract first histogram-only pass in DeviceTopK into its own kernel#8299
Open
elstehle wants to merge 3 commits intoNVIDIA:mainfrom
Open
Extract first histogram-only pass in DeviceTopK into its own kernel#8299elstehle wants to merge 3 commits intoNVIDIA:mainfrom
DeviceTopK into its own kernel#8299elstehle wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 27m: Pass: 100%/269 | Total: 2d 22h | Max: 1h 08m | Hits: 96%/176727See results here. |
Contributor
|
I think we would want to benchmark the changes? Or is there a reason this is not needed? |
Contributor
Author
No, definitely, we should. I had that as an open task in the PR description but must have accidentally removed it while editing 🙈 |
Contributor
Contributor
Author
|
Performance results for pairs:
H100 PCIe |
Contributor
Author
|
Performance results for keys:
H100 PCIe |
Contributor
Author
|
Overall, performance regressions are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extracts the first-pass histogram-only code path from the fused filter+histogram kernel into a dedicated DeviceTopKHistogramKernel, removing the IsFirstPass template parameter and simplifying the fused kernel.
Background:
DeviceTopKworks in passes. With each pass, we "partition" items into "selected", "candidates", and "rejected".DeviceTopKdoes. However, for the very first pass, there's just a stand-alone histogram computation. This PR extracts this histogram-only computation into its own kernel.Partially addresses #6191
Open tasks: