Move definitions of BenchResult and dependencies to a separate file#8319
Open
oleksandr-pavlyk wants to merge 1 commit intoNVIDIA:mainfrom
Open
Move definitions of BenchResult and dependencies to a separate file#8319oleksandr-pavlyk wants to merge 1 commit intoNVIDIA:mainfrom
oleksandr-pavlyk wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ffef5a7 to
c8bab52
Compare
Contributor
Author
|
/ok to test 3122e05 |
Contributor
🥳 CI Workflow Results🟩 Finished in 22m 39s: Pass: 100%/4 | Total: 1h 09m | Max: 22m 36s | Hits: 94%/2620See results here. |
…te file Similar for JsonCache, and ProcessRunner.
3122e05 to
1715519
Compare
Contributor
Author
|
Tested the change to Python scripts by invoking Output of invoking run.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move definitions of
BenchResultand downstream dependencies to separate filebench_result.py.Similarly, moved definition of
JsonCachesingleton and functions that use to to a dedicate filejson_cache.py, and definition ofProcessRunnerclass toprocess_runner.py.The intent is to migrate
bench_result.pyto nvbench eventually to support using NVBench in hyper-parameter optimization tools.Description
closes
Checklist