Skip to content

Move definitions of BenchResult and dependencies to a separate file#8319

Open
oleksandr-pavlyk wants to merge 1 commit intoNVIDIA:mainfrom
oleksandr-pavlyk:break-cccl-bench-into-smaller-files
Open

Move definitions of BenchResult and dependencies to a separate file#8319
oleksandr-pavlyk wants to merge 1 commit intoNVIDIA:mainfrom
oleksandr-pavlyk:break-cccl-bench-into-smaller-files

Conversation

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Apr 7, 2026

Move definitions of BenchResult and downstream dependencies to separate file bench_result.py.

Similarly, moved definition of JsonCache singleton and functions that use to to a dedicate file json_cache.py, and definition of ProcessRunner class to process_runner.py.

The intent is to migrate bench_result.py to nvbench eventually to support using NVBench in hyper-parameter optimization tools.

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot bot commented Apr 7, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Progress in CCCL Apr 7, 2026
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the break-cccl-bench-into-smaller-files branch from ffef5a7 to c8bab52 Compare April 7, 2026 20:24
@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor Author

/ok to test 3122e05

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

🥳 CI Workflow Results

🟩 Finished in 22m 39s: Pass: 100%/4 | Total: 1h 09m | Max: 22m 36s | Hits: 94%/2620

See results here.

…te file

Similar for JsonCache, and ProcessRunner.
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the break-cccl-bench-into-smaller-files branch from 3122e05 to 1715519 Compare April 8, 2026 13:30
@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review April 8, 2026 13:33
@oleksandr-pavlyk oleksandr-pavlyk requested a review from a team as a code owner April 8, 2026 13:33
@oleksandr-pavlyk oleksandr-pavlyk requested a review from shwina April 8, 2026 13:33
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Apr 8, 2026
@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor Author

Tested the change to Python scripts by invoking benchmarks/scripts.run.py:

Output of invoking run.py
cccl) coder ➜ ~/cccl/build/cuda13.1-gcc14/cub $ CUDA_VISIBLE_DEVICES=0 PYTHONPATH=${PYTHONPATH}:${HOME}/cccl/benchmarks/scripts python ~/cccl/benchmarks/scripts/run.py -R "^.*babelstream.*"
&&&& RUNNING bench
 ctk:  13.1.115
cccl:  v3.4.0.dev-503-g6e84c284b1
&&&& PERF cub_bench_transform_babelstream_mul_T_ct__I8___OffsetT_ct__I64___Elements_io__pow2__32 0.012579839676618576 -sec
&&&& PERF cub_bench_transform_babelstream_add_T_ct__I8___OffsetT_ct__I64___Elements_io__pow2__32 0.018774015828967094 -sec
&&&& PERF cub_bench_transform_babelstream_triad_T_ct__I8___OffsetT_ct__I64___Elements_io__pow2__32 0.018999295309185982 -sec
&&&& PERF cub_bench_transform_babelstream_nstream_T_ct__I8___OffsetT_ct__I64___Elements_io__pow2__32 0.02476160041987896 -sec
&&&& PERF cub_bench_transform_babelstream_mul_T_ct__I16___OffsetT_ct__I64___Elements_io__pow2__32 0.025427967309951782 -sec
&&&& PERF cub_bench_transform_babelstream_add_T_ct__I16___OffsetT_ct__I64___Elements_io__pow2__32 0.03751014173030853 -sec
&&&& PERF cub_bench_transform_babelstream_triad_T_ct__I16___OffsetT_ct__I64___Elements_io__pow2__32 0.03751833736896515 -sec
&&&& PERF cub_bench_transform_babelstream_nstream_T_ct__I16___OffsetT_ct__I64___Elements_io__pow2__32 0.048870399594306946 -sec
&&&& PERF cub_bench_transform_babelstream_mul_T_ct__F32___OffsetT_ct__I64___Elements_io__pow2__32 0.0503116138279438 -sec
&&&& PASSED bench

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

1 participant