Refactor radix rank sort operations#8331
Open
bernhardmgruber wants to merge 1 commit intoNVIDIA:mainfrom
Open
Conversation
bernhardmgruber
commented
Apr 8, 2026
Comment on lines
255
to
266
| template <class DecomposerT> | ||
| struct min_raw_binary_key_f | ||
| { | ||
| DecomposerT decomposer; | ||
|
|
||
| template <class T> | ||
| _CCCL_HOST_DEVICE void operator()(T& field) | ||
| { | ||
| using traits = traits_t<::cuda::std::remove_cv_t<T>>; | ||
| using bit_ordered_type = typename traits::bit_ordered_type; | ||
| using traits = traits_t<::cuda::std::remove_cv_t<T>>; | ||
| using bit_ordered_type = typename traits::bit_ordered_type; | ||
| // TODO(bgruber): was it intended to pass decomposer here instead of identity_decomposer_t? | ||
| reinterpret_cast<bit_ordered_type&>(field) = traits::min_raw_binary_key(detail::identity_decomposer_t{}); |
Contributor
Author
There was a problem hiding this comment.
@gevtushenko was this intended to be recursive?
miscco
approved these changes
Apr 8, 2026
| { | ||
| static constexpr bool value = false; | ||
| }; | ||
| inline constexpr bool is_fundamental_type = false; |
Contributor
There was a problem hiding this comment.
Nitpick: I would prefer if that would be something like is_decomposable
is_fundamental is already taken an means a different thing https://en.cppreference.com/w/cpp/types/is_fundamental.html
| { | ||
| using traits = traits_t<::cuda::std::remove_cv_t<T>>; | ||
| using bit_ordered_type = typename traits::bit_ordered_type; | ||
| using traits = traits_t<::cuda::std::remove_cv_t<T>>; |
Contributor
There was a problem hiding this comment.
Nitpick: can we move the remove_cv into the traits_t alias?
Contributor
😬 CI Workflow Results🟥 Finished in 1h 42m: Pass: 88%/269 | Total: 5d 01h | Max: 1h 10m | Hits: 88%/171067See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.