__aggregate_all_of Internal utility to recursively apply a predicate to aggregate members#8347
Open
fbusato wants to merge 3 commits intoNVIDIA:mainfrom
Open
__aggregate_all_of Internal utility to recursively apply a predicate to aggregate members#8347fbusato wants to merge 3 commits intoNVIDIA:mainfrom
__aggregate_all_of Internal utility to recursively apply a predicate to aggregate members#8347fbusato wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 45m: Pass: 100%/108 | Total: 19h 46m | Max: 1h 36m | Hits: 99%/281804See results here. |
Contributor
Author
|
@miscco @davebayer @gevtushenko considering the complexity, the impact on compile time, and a couple of compatibility problems with MSVC, I'm not 100% sure it worth to add it. details:
|
Member
I remember vaguely finding this trick before and decided to write it off based on this. I think we should wait for proper reflection unless this immediately solves problems of our own making internally where we can control what goes through the machinery. If we can get a guarantee that this will only be used with well supported input types, then I'd consider approving this. Otherwise leaving a footgun laying around concerns me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
__aggregate_all_ofis useful to extract properties for custom traits.Extract from:
cuda::is_trivially_copyable#8265