-
Notifications
You must be signed in to change notification settings - Fork 13
Feature/627 step config #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
089c0e8
WIP for #627
oharsta 9710e19
WIP for #627
oharsta 303eb79
Upped dependencies
oharsta 574ed69
WIP for #672
oharsta dc2c543
Merge branch 'main' into feature/627-step-config
oharsta 4295bb7
WIP for #627
oharsta 24ab0d7
WIP for #627
oharsta df93e8e
WIP for #627
oharsta ad55130
Fixed build
oharsta edd780f
Added attributes to SFO collection
oharsta be3de6c
Typo
oharsta 77e8563
Only add the stepup_config sections if present
oharsta 553d82d
Push and import Stepup entities #627
oharsta 7ef3255
Fixed #627 build
oharsta 4db9e3a
#627 Delete SFO and institution entities
oharsta 9adba68
Bugfix for errors
oharsta 1740405
Stepu push
oharsta fb345a1
Fixed tests
oharsta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,40 +1,46 @@ | ||
| import js from "@eslint/js"; | ||
| import globals from "globals"; | ||
| import pluginReact from "eslint-plugin-react"; | ||
| import reactHooks from 'eslint-plugin-react-hooks'; | ||
| import react from "eslint-plugin-react"; | ||
| import reactHooks from "eslint-plugin-react-hooks"; | ||
| import { defineConfig } from "eslint/config"; | ||
|
|
||
| export default defineConfig([ | ||
| { | ||
| ignores: ["dist/**","node/**"], | ||
| ignores: ["dist/**", "node_modules/**"], | ||
| }, | ||
|
|
||
| js.configs.recommended, | ||
| react.configs.flat.recommended, | ||
| reactHooks.configs.flat.recommended, | ||
|
|
||
| { | ||
| files: ["**/*.{js,mjs,cjs,jsx}"], | ||
|
|
||
| plugins: { | ||
| js , | ||
| 'react-hooks': reactHooks | ||
| react, | ||
| "react-hooks": reactHooks, | ||
| }, | ||
| extends: ["js/recommended"], | ||
| languageOptions: { globals: globals.browser }, | ||
|
|
||
| languageOptions: { | ||
| globals: globals.browser, | ||
| }, | ||
|
|
||
| settings: { | ||
| react: { | ||
| version: "detect", | ||
| }, | ||
| }, | ||
| }, | ||
| pluginReact.configs.flat.recommended, // React config first | ||
| reactHooks.configs.flat.recommended, | ||
| { | ||
|
|
||
| rules: { | ||
| "react/prop-types": "off", | ||
| "react/no-children-prop": "off", | ||
| 'react-hooks/exhaustive-deps': 'warn', | ||
| "react/react-in-jsx-scope" : "off", | ||
| "react/react-in-jsx-scope": "off", | ||
| "react/no-deprecated": "off", | ||
| "react/no-unsafe": "off", | ||
|
|
||
| "react-hooks/exhaustive-deps": "warn", | ||
| "react-hooks/set-state-in-effect": "warn", | ||
| "react-hooks/immutability":"off", | ||
| "react/no-deprecated": "off", // ReactDOM.unmountComponentAtNode / andere deprecated APIs | ||
| "react/no-unsafe": "off", // componentWillReceiveProps, componentWillMount, etc | ||
| "react-hooks/immutability": "off", | ||
| }, | ||
| }, | ||
|
|
||
| ]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The organization/institution column rendering logic is inconsistent with the table headers: for non-policy/non-organisation types the organization cell is now always empty (because it only renders when
isInstitutionis true), and for institutions the same cell tries to render both organization and identifier. Adjust the conditions so regular metadata types render the organisation name, institutions render the identifier in their dedicated column, and SFOs don’t render an empty organization column.