Open
Conversation
larshg
added
changelog: enhancement
larshg
force-pushed
the
gp3Improvements
branch
from
08f04a6 to
7b96ac9
Compare
larshg
force-pushed
the
gp3Improvements
branch
from
7b96ac9 to
2c172d6
Compare
mvieth
reviewed
Apr 12, 2026
| } | ||
|
|
||
| // Sorting angles | ||
| std::sort (angles_.begin (), angles_.end (), GreedyProjectionTriangulation<PointInT>::nnAngleSortAsc); |
Member
There was a problem hiding this comment.
Previously, this also sorted the invisible angles (so the angle list first had all visible angles in ascending order, then all invisible angles in ascending order). In your proposal, the invisible angles are not sorted. I do not know if that is relevant?
Comment on lines
+174
to
176
| if (state_[R_] != FREE) | ||
| continue; | ||
| { |
Member
There was a problem hiding this comment.
Suggested change
| if (state_[R_] != FREE) | |
| continue; | |
| { | |
| if (state_[R_] != FREE) { | |
| continue; | |
| } else { |
This looks a bit strange, as if the curly opening brace also belongs to the if-statement. I think putting an else in there would make it clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before changes:
After changes:
Helps on #6370
@abstig can you test it?