fix: propagate setIndices to correspondence estimation in registration#6425
Open
AlrIsmail wants to merge 1 commit intoPointCloudLibrary:masterfrom
Open
fix: propagate setIndices to correspondence estimation in registration#6425AlrIsmail wants to merge 1 commit intoPointCloudLibrary:masterfrom
AlrIsmail wants to merge 1 commit intoPointCloudLibrary:masterfrom
Conversation
a59bb98 to
35ead9c
Compare
35ead9c to
46d0a68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issue #3109 where
pcl::IterativeClosestPoint(and other registration algorithms inheriting frompcl::Registration) were ignoring indices set viasetIndices().The root cause was that while
PCLBasestored the indices, theRegistrationclass was not propagating them to theCorrespondenceEstimationobject or the reciprocal search tree during the initialization phase (initCompute). This resulted in the algorithm always searching the full input cloud regardless of user-provided constraints.Changes
registration.hpp:initCompute()to propagateindices_to thecorrespondence_estimation_object.initComputeReciprocal()to utilizePCLBase::initCompute()for consistent initialization and ensured the reciprocal search tree respects the input indices.test_registration.cpp:IterativeClosestPoint_setIndicesthat verifies the transformation result withsetIndicesis identical to physically cropping the point cloud.Verification
PCL.IterativeClosestPoint_setIndicespasses successfully along with other existing tests.