-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Enable unused-import in ruff
#15940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Cryoris
wants to merge
18
commits into
Qiskit:main
Choose a base branch
from
Cryoris:ruff/unused-imports
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enable unused-import in ruff
#15940
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
57ae9ac
Remove unused imports
Cryoris 52f59ea
Enable F401
Cryoris 0c89b19
Use documented path over internal paths
Cryoris 19f6966
undo formatting changes to `pyproject.toml`
Cryoris c2fa0d2
Forgot committing QPY test
Cryoris a1b069b
Apply CPR on ``qiskit.quantum_info.random``
Cryoris 579e599
start putting __all__
Cryoris 42e1a7c
Wrap up the __all__ excursion
Cryoris ddf463e
Merge branch 'main' into ruff/unused-imports
Cryoris 700442e
Update from `main`
Cryoris 516ed69
`make lint` doesn't run `make black`?
Cryoris 9df35b5
Some "annotations" snuck in
Cryoris 486d33a
undo changes to `pyproject.toml`
Cryoris 98ae527
Use star imports
Cryoris 8b4e471
Merge branch 'main' into ruff/unused-imports
Cryoris 65b236d
More star imports and main fixup
Cryoris f53693f
Merge branch 'main' into ruff/unused-imports
Cryoris 96d4cb4
Fix new ruff issues from main
Cryoris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,3 +39,8 @@ | |
| """ | ||
|
|
||
| from . import types, expr | ||
|
|
||
| __all__ = [ | ||
| "expr", | ||
| "types", | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you undo these formatting changes to the TOML file - if we're going to apply a formatter to our TOML files, we should be consistent about it and enforce it in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah crap -- I usually remember to save w/o formatting but here it snuck in 🙂 thanks!