Skip to content

[TRITON] Add unified attention support to bench_models#2724

Open
lucas-santos-amd wants to merge 1 commit intomainfrom
lusantos/add_unified_attn_to_bench_models
Open

[TRITON] Add unified attention support to bench_models#2724
lucas-santos-amd wants to merge 1 commit intomainfrom
lusantos/add_unified_attn_to_bench_models

Conversation

@lucas-santos-amd
Copy link
Copy Markdown
Contributor

Motivation

  • Add unified attention support to the bench_models.py benchmarking script.
  • Add sink and window support to the MHA kernel handler.

Technical Details

Test Plan

Test Result

Submission Checklist

@lucas-santos-amd lucas-santos-amd self-assigned this Apr 13, 2026
@lucas-santos-amd lucas-santos-amd requested a review from a team April 13, 2026 19:17
@lucas-santos-amd lucas-santos-amd added enhancement New feature or request triton labels Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-355 Run Triton tests on MI355 in addition to MI325
ci:sglang SGLang integration tests
ci:atom ATOM benchmark (DeepSeek-R1 + GPT-OSS)
ci:vllm vLLM benchmark
ci:all All of the above

Add labels via the sidebar or gh pr edit 2724 --add-label <label>

@lucas-santos-amd lucas-santos-amd force-pushed the lusantos/add_unified_attn_to_bench_models branch from ac79d01 to 192e1b6 Compare April 13, 2026 19:28
brunomazzottiamd

This comment was marked as resolved.

Add sink and window support to mha handler
@lucas-santos-amd lucas-santos-amd force-pushed the lusantos/add_unified_attn_to_bench_models branch from 192e1b6 to 7ed61b1 Compare April 14, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request triton

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants