Skip to content

[Flang] Fix xfail with non compiler tweak #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronlieb merged 1 commit into from
Apr 14, 2026
+4 −5
Merged

[Flang] Fix xfail with non compiler tweak #2172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions clang/lib/Driver/ToolChains/AMDGPU.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,8 +920,7 @@ void AMDGPUToolChain::addClangTargetOptions(
// Default to "hidden" visibility, as object level linking will not be
// supported for the foreseeable future.
if (!DriverArgs.hasArg(options::OPT_fvisibility_EQ,
options::OPT_fvisibility_ms_compat) &&
!getDriver().IsFlangMode()) {
options::OPT_fvisibility_ms_compat)) {
CC1Args.push_back("-fvisibility=hidden");
CC1Args.push_back("-fapply-global-visibility-to-externs");
}
Expand Down
4 changes: 2 additions & 2 deletions flang/test/Lower/AMDGPU/allocate_deallocate_runtime_calls.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
! RUN: %flang -target amdgcn-- -mmlir -use-alloc-runtime -S -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK
! RUN: %flang -target amdgcn-- -S -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-NO-FLAG
! RUN: %flang --offload-targets=amdgcn-amd-amdhsa -mmlir -use-alloc-runtime -S -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK
! RUN: %flang --offload-targets=amdgcn-amd-amdhsa -S -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-NO-FLAG

! Test to check if usage of flag -use-alloc-runtime results in runtime calls.

Expand Down
2 changes: 1 addition & 1 deletion flang/test/Lower/AMDGPU/allocate_runtime_alloc_idx.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
! RUN: %flang -target amdgcn-- -ffast-amd-memory-allocator -S -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK
! RUN: %flang -ffast-amd-memory-allocator -S -emit-llvm --offload-targets=amdgcn-amd-amdhsa -o - %s | FileCheck %s

subroutine allocate_deallocate()
real, allocatable :: x
Expand Down
Loading